Color Picker: Match figma metrics. #35039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
requested review from
ajitbohra and
chrisvanpatten
as code owners
| border: ${ CONFIG.borderWidthFocus } solid rgba( 255, 255, 255, 0 ); | ||
| box-shadow: inset 0px 0px 0px ${ CONFIG.borderWidthFocus } #ffffff; | ||
| border: none; | ||
| box-shadow: 0 0 2px 0 rgba( 0, 0, 0, 0.25 ); |
There was a problem hiding this comment.
Would it make sense to use ${ CONFIG.radiusBlockUi } (2px) instead of hardcoded 2px?
There was a problem hiding this comment.
Yes! I'll make that happen.
There was a problem hiding this comment.
Well, sorry no, that makes sense for replacing border-radius: 2px, but not for the shadow. We want a separate box shadow value for this one, something a la ${ CONFIG.elevation1 } or something.
There was a problem hiding this comment.
Got it, in that case feel free to merge the PR 👍
There was a problem hiding this comment.
Thanks. Can I get a green check?
gwwar
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #34598. This one changes the handle to use a box-shadow with a fallback transparent outline for Windows High Contrast mode. This lets us match the Figma specs:
Checklist:
*.native.jsfiles for terms that need renaming or removal).