Remove: Unrequired regex search on duotone supports. #42020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Performance
37 tasks
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Sep 8, 2022
This add the ability to unset duotone in themes with default duotone set. This commit backports the original PRs from Gutenberg repository: * [WordPress/gutenberg#39564 #39564: Add ability to unset duotone in themes with default duotone set] * [WordPress/gutenberg#42020 #42020: Remove: Unrequired regex search on duotone supports] Follow-up to [50929], [52757]. Props ajlende, jorgefilipecosta, Joen, cbravobernal. See #56467. Built from https://develop.svn.wordpress.org/trunk@54101 git-svn-id: http://core.svn.wordpress.org/trunk@53660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Sep 8, 2022
This add the ability to unset duotone in themes with default duotone set. This commit backports the original PRs from Gutenberg repository: * [WordPress/gutenberg#39564 #39564: Add ability to unset duotone in themes with default duotone set] * [WordPress/gutenberg#42020 #42020: Remove: Unrequired regex search on duotone supports] Follow-up to [50929], [52757]. Props ajlende, jorgefilipecosta, Joen, cbravobernal. See #56467. Built from https://develop.svn.wordpress.org/trunk@54101 git-svn-id: https://core.svn.wordpress.org/trunk@53660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pbearne
pushed a commit
to pbearne/wordpress-develop
that referenced
this pull request
Sep 9, 2022
This add the ability to unset duotone in themes with default duotone set. This commit backports the original PRs from Gutenberg repository: * [WordPress/gutenberg#39564 #39564: Add ability to unset duotone in themes with default duotone set] * [WordPress/gutenberg#42020 #42020: Remove: Unrequired regex search on duotone supports] Follow-up to [50929], [52757]. Props ajlende, jorgefilipecosta, Joen, cbravobernal. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54101 602fd350-edb4-49c9-b593-d223f7449a82
whereiscodedude
pushed a commit
to whereiscodedude/wpss
that referenced
this pull request
Sep 18, 2022
This add the ability to unset duotone in themes with default duotone set. This commit backports the original PRs from Gutenberg repository: * [WordPress/gutenberg#39564 #39564: Add ability to unset duotone in themes with default duotone set] * [WordPress/gutenberg#42020 #42020: Remove: Unrequired regex search on duotone supports] Follow-up to [50929], [52757]. Props ajlende, jorgefilipecosta, Joen, cbravobernal. See #56467. Built from https://develop.svn.wordpress.org/trunk@54101
ootwch
pushed a commit
to ootwch/wordpress-develop
that referenced
this pull request
Nov 4, 2022
This add the ability to unset duotone in themes with default duotone set. This commit backports the original PRs from Gutenberg repository: * [WordPress/gutenberg#39564 #39564: Add ability to unset duotone in themes with default duotone set] * [WordPress/gutenberg#42020 #42020: Remove: Unrequired regex search on duotone supports] Follow-up to [50929], [52757]. Props ajlende, jorgefilipecosta, Joen, cbravobernal. See #56467. git-svn-id: https://develop.svn.wordpress.org/trunk@54101 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces a preg_replace replacement with a simple string replacement which is much more performant and is enough in this case.