Simplify BlockStyles preview by removing the slot #44825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
draganescu,
talldan,
noisysocks,
tellthemachines,
adamziel,
kevin940726 and
ellatrix
as code owners
|
Size Change: -141 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
This is looking good to me. Thanks for improving the code!! 🙇
I checked that the block style preview appears to the left of the block style buttons, and that there was no loss of functionality:
2022-10-11.15.58.59.mp4
Also can confirm that the block previews do not show in narrow viewport widths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to the discussion here #34522 (comment)
What?
This is a small refactoring to the block styles preview to avoid relying on Slot/Fill
Why?
We have too many slots and boilerplate code we need to write every time we want to build a new block editor instance. This PR just removes one of these Slots and make the preview contextual to the BlockStyles element instead.
The difference with trunk is that instead of the styles preview showing up at the top of the canvas, they will be aligned with the "Styles panel" instead.
Testing Instructions
1- Select a block with styles variations like "Button"
2- Hover the style variations in the sidebar
3- The preview should show up at the left of the buttons.
Screenshots or screencast