Tag processor/dangerously replace contents #46080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dmsnell
commented
Nov 25, 2022
dmsnell
commented
…ns in document It can be helpful to track a location in an HTML document while updates are being made to it such that we can instruct the Tag Processor to seek to the location of one of the bookmarks. In this patch we're introducing a bookmarks system to do just that. The bookmark is a resource handle that represents an internal tracking object which will follow all updates made to the document. It will be possible to rewind or jump around a document by setting a bookmark.
|
|
adamziel
reviewed
Nov 27, 2022
| while ( $depth > 0 && $p->next_tag( [ 'tag_name' => $tag, 'tag_closers' => 'visit' ] ) ) { | ||
| $depth += $p->is_tag_closer() ? -1 : 1; | ||
|
|
||
| if ( $depth === 0 ) { |
There was a problem hiding this comment.
Error out if the closer has a different tag name than the opener?
ockham
force-pushed
the
tag-processor/add-bookmarks
branch
from
c5f3cc0
to
bc7221f
Compare
dmsnell
force-pushed
the
tag-processor/add-bookmarks
branch
3 times, most recently
from
6026b5d
to
5fcf00d
Compare
This was referenced Dec 13, 2022
gziolo
added
the
[Feature] Block API
gziolo
added
[Feature] HTML API
|
Closing because this is outdated and work has moved into Core to explore this in dmsnell/wordpress-develop#6 and adamziel/wordpress-develop#2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.