Global styles: relocate Background Image controls to sit under Layout #61886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove Background image top-level navigation item - relocate background panel to sit next to Layout controls
ramonjd
added
[Type] Feedback
ramonjd
requested review from
noisysocks,
jameskoster,
jasmussen,
tellthemachines and
andrewserong
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
added
[Type] Feature
69 tasks
|
Size Change: -257 B (-0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 15da58e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9200539505
|
jasmussen
approved these changes
May 23, 2024
There was a problem hiding this comment.
This feels like a good interim state for the feature. It allows it to ship, be iterated, and it's grouped with styles that are perhaps also not ideally placed, but nevertheless are related in a "global" context.
Notably it doesn't preclude future improvements and a clearer hierarchy, as we've discussed in other tickets.
|
Hi Ramon, just noting that the commit titles appear on #core slack, so we should try to make the commit titles a bit more comprehensible as much as we can when merging PRs. Thank you. |
Thanks for the ping @youknowriad This appears to be a limitation with the slack bot. I see that it only picked up the first line, but my commit message was sufficiently comprehensive in my opinion.
So that means we need to use one liners in our commit messages to appease the core slack bot 😆 |
|
Oh, the slack bot picks up the PR title. The title was always In any case I've added a comment in a thread in #core to elaborate. |
|
Definitely a bug in slack bot. Sorry for not noticing :) |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
- remove Background image top-level navigation item - relocate background panel to sit next to Layout controls Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
- remove Background image top-level navigation item - relocate background panel to sit next to Layout controls Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR relocates the Background Image controls to sit under Layout in the global styles sidebar.
It also removes the Background image top-level navigation item.
Background image controls were originally added to global styles in #59454
There are no modifications to functionality.
Why?
The global styles taxonomy is under review and will likely change between now and WordPress 6.7.
See discussion:
The ambition in this PR is to make a low-impact change to the global styles taxonomy until these changes are implemented.
How?
Just movin' stuff around.
Testing Instructions
The main concern here is whether the location of Background controls, despite it being temporary, is a reasonable step and won't introduce too much confusion.
Furthermore, as no functionality is being introduced, it would be great to smoke test that the background controls work as they should, e.g.,
Screenshots or screencast