Try: Improved editor inserter tabs styles #61974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
DaniGuardiola
requested review from
a team and
ramonjd
and removed request for
a team
DaniGuardiola
added
[Type] Enhancement
|
Size Change: -90 B (-0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
tyxla
reviewed
May 27, 2024
There was a problem hiding this comment.
To be fair, I prefer how it was before.
From what I understand, we try to keep the tabs occupying all the horizontal space, which made even more visual sense when the X button wasn't there. Even with the X button though, it's OK for them to be wider and occupying more space, there's not much else to do with that space and folks are likely used to have larger inserter category tabs.
This is something @WordPress/gutenberg-design should have a good sense about.
|
Thanks for your attention to detail. There's an ongoing conversation about these changes, maybe @richtabor has more info. |
|
There is a discrepancy between the tabs in the Inserter and the Inspector, but I am cautious to reduce the surface area of the Inserter tabs. Here's the state of the tabs: Current:
Proposed:
|
|
And here's a counter, if we applied the same positioning logic that exists in the Inserter to the Inspector tabs:
Not a formal proposal; an exploration. |
|
Thanks for the visuals, very helpful @richtabor. I think I strongly prefer the first option, personally. |
Yes, and I reported the inconsistencies in #62025 To me, tabs should have the same alignment / layout everywhere. Worth reminding the X close button is candidate to be removed from there, as it breaks the ARIA tabs pattern. See #59013 / #58940 As per @DaniGuardiola proposal in this PR, I support the left alignment option. To me, it doesn't make much sense attempting to have a balanced equal width because the length fo the tabs content is not predictable. It may look niced in English, which usually has shorter strings, but it's a bit pointless with longer / uneven strings in other languages. |
|
If the consensus is in favor of the left-aligned instead of balanced-width tabs, I'm fine with that 👍 |
This is the aim of the component I am proposing in #62343 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The styles of these tabs look broken to me, with weird padding. Looks unnaturally stretched out and each of the tabs is uncentered:
chrome_DItpzeDWwt.mp4
After removing these custom styles, it looks much better with the default sizing IMO:
chrome_IBPPwFshCW.mp4