Try: Improved tabbed sidebar styles #61974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
DaniGuardiola
requested review from
a team and
ramonjd
and removed request for
a team
DaniGuardiola
added
[Type] Enhancement
|
Size Change: -65 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
tyxla
reviewed
May 27, 2024
There was a problem hiding this comment.
To be fair, I prefer how it was before.
From what I understand, we try to keep the tabs occupying all the horizontal space, which made even more visual sense when the X button wasn't there. Even with the X button though, it's OK for them to be wider and occupying more space, there's not much else to do with that space and folks are likely used to have larger inserter category tabs.
This is something @WordPress/gutenberg-design should have a good sense about.
|
Thanks for your attention to detail. There's an ongoing conversation about these changes, maybe @richtabor has more info. |
|
There is a discrepancy between the tabs in the Inserter and the Inspector, but I am cautious to reduce the surface area of the Inserter tabs. Here's the state of the tabs: Current:
Proposed:
|
|
And here's a counter, if we applied the same positioning logic that exists in the Inserter to the Inspector tabs:
Not a formal proposal; an exploration. |
|
Thanks for the visuals, very helpful @richtabor. I think I strongly prefer the first option, personally. |
Yes, and I reported the inconsistencies in #62025 To me, tabs should have the same alignment / layout everywhere. Worth reminding the X close button is candidate to be removed from there, as it breaks the ARIA tabs pattern. See #59013 / #58940 As per @DaniGuardiola proposal in this PR, I support the left alignment option. To me, it doesn't make much sense attempting to have a balanced equal width because the length of the tabs content is not predictable. It may look nice in English, which usually has shorter strings, but it's a bit pointless with longer / uneven strings in other languages. |
|
If the consensus is in favor of the left-aligned instead of balanced-width tabs, I'm fine with that 👍 |
This is the aim of the component I am proposing in #62343 |
…ix/editor-inserter-tabs-styles
DaniGuardiola
changed the title
|
I've updated the PR after @scruffian's work to unify sidebar, and also edited the description to more clearly state the issues and how this PR addresses it. I'd like to seek some consensus around this to hopefully make a decision. cc @WordPress/gutenberg-design @WordPress/gutenberg-components @richtabor @tyxla @afercia |
|
There are also these tabs in the Inspector: 
I agree the behavior should be consistent across. The example above would look quite strange if the icons were aligned left. Looking at the component objectively, centrally aligning the label seems simplest, likely with a prop to specify when the row should fill the container or not.
There could also be a prop to left-align the label/icon, but I'm not entirely convinced it's worth the added complexity. |
Yes, and the Navigation block shows 3 icon-tabs:
I have a solution for that: use text instead of icons by default 🥳 Worth reminding that enabling the 'Show button text labels' preference already switches those tab icons to text, and the alignment is still inconsistent:
|
|
I think those tabs are a different (but definitely related) issue. This PR focuses on the tabbed sidebar layout, currently only present in inserter and list view, but planned for other similar sidebars across the app (see #62343 for full context). I personally feel like what needs to be consistent is this component (tabbed sidebar), and it doesn't feel weird if other tabs like that example have a different layout (especially since it is already quite different by having icon labels instead of text). With that in mind, and if we agree on that, I'm happy to discuss more about those tabs. My hunch is that it might justify a "balanced" variant for icon-based tabs, some notes:
I agree. I think for this "balanced" variant, labels (in this case icons) should indeed be centered.
Agreed. I think the variant should probably revert to the default "left-aligned" layout when the preference is enabled. Feels like it should be implemented at the usage/product level though, and not at the component level, since the preference is a product-level feature. |
I'd agree the inconsistent layout with other tabs isn't a blocker for this PR, which is an improvement. I'd encourage to moev on with this PR as long as there is a follow-up to better consider consistent alignment for all tabs across the entire editor UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the "balanced" tabs styles, as it overrides the built-in Tabs styles - we're trying to avoid and remove style overrides in the components package for many reasons. @afercia discussed tabs styles here: #62025
If we want these styles to be an option for Tabs, then it should be proposed, discussed and implemented in the Tabs component directly. These styles, though, present some problems beyond aesthetic concerns, notably it could behave badly in other languages since the length of the labels is unpredictable (see @afercia's comment: #61974 (comment))
Before:
chrome_DItpzeDWwt.mp4
After:
Note that this PR also removes a few styles that were completely redundant (basically all but the negative bottom margin).