Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SLACK_WEBHOOK_TYPE env var to reporting job #1131

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Apr 4, 2023

Description

Contrary to the expectations set in #1066, a bland and unhelpful report was received.

Screenshot 2023-04-04 at 2 22 48 PM

This PR rectifies that.

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: mgmt Related to repo management and automations labels Apr 4, 2023
@dhruvkb dhruvkb requested a review from a team as a code owner April 4, 2023 10:24
@github-actions github-actions bot added 🧱 stack: api Related to the Django API 🧱 stack: ingestion server Related to the ingestion/data refresh server 🧱 stack: frontend Related to the Nuxt frontend labels Apr 4, 2023
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Size Change: 0 B

Total Size: 844 kB

ℹ️ View Unchanged
Filename Size
./frontend/.nuxt/dist/client/235.js 273 B
./frontend/.nuxt/dist/client/235.modern.js 278 B
./frontend/.nuxt/dist/client/236.js 1.85 kB
./frontend/.nuxt/dist/client/app.js 126 kB
./frontend/.nuxt/dist/client/app.modern.js 117 kB
./frontend/.nuxt/dist/client/commons/app.js 90.3 kB
./frontend/.nuxt/dist/client/commons/app.modern.js 78.5 kB
./frontend/.nuxt/dist/client/components/loading-icon.js 752 B
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 757 B
./frontend/.nuxt/dist/client/components/table-sort-icon.js 515 B
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 518 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 5.63 kB
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 5.48 kB
./frontend/.nuxt/dist/client/components/v-audio-cell.js 392 B
./frontend/.nuxt/dist/client/components/v-audio-cell.modern.js 397 B
./frontend/.nuxt/dist/client/components/v-audio-details.js 2.56 kB
./frontend/.nuxt/dist/client/components/v-audio-details.modern.js 1.8 kB
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 1.02 kB
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.02 kB
./frontend/.nuxt/dist/client/components/v-audio-track.js 5.26 kB
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 5.21 kB
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 542 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 548 B
./frontend/.nuxt/dist/client/components/v-bone.js 689 B
./frontend/.nuxt/dist/client/components/v-bone.modern.js 693 B
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.28 kB
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.28 kB
./frontend/.nuxt/dist/client/components/v-content-link.js 1.12 kB
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.1 kB
./frontend/.nuxt/dist/client/components/v-content-page.js 526 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 530 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 787 B
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 790 B
./frontend/.nuxt/dist/client/components/v-content-report-form.js 3.77 kB
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.59 kB
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 1.24 kB
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 4.25 kB
./frontend/.nuxt/dist/client/components/v-copy-button.js 4 kB
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 4.01 kB
./frontend/.nuxt/dist/client/components/v-copy-license.js 1 kB
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 1 kB
./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.js 9.96 kB
./frontend/.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/d219393b.modern.js 9.94 kB
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 754 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 758 B
./frontend/.nuxt/dist/client/components/v-error-image.js 1.69 kB
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 1.68 kB
./frontend/.nuxt/dist/client/components/v-error-section.js 372 B
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 376 B
./frontend/.nuxt/dist/client/components/v-external-search-form.js 1.93 kB
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 1.92 kB
./frontend/.nuxt/dist/client/components/v-external-source-list.js 906 B
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 907 B
./frontend/.nuxt/dist/client/components/v-full-layout.js 1.52 kB
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 1.52 kB
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.61 kB
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.62 kB
./frontend/.nuxt/dist/client/components/v-home-gallery.js 5.18 kB
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 5.17 kB
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.76 kB
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.72 kB
./frontend/.nuxt/dist/client/components/v-image-carousel.js 4.73 kB
./frontend/.nuxt/dist/client/components/v-image-carousel.modern.js 4.72 kB
./frontend/.nuxt/dist/client/components/v-image-cell.js 1.59 kB
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 1.59 kB
./frontend/.nuxt/dist/client/components/v-image-details.js 2.17 kB
./frontend/.nuxt/dist/client/components/v-image-details.modern.js 1.43 kB
./frontend/.nuxt/dist/client/components/v-image-grid.js 2.66 kB
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 2.54 kB
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 526 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 528 B
./frontend/.nuxt/dist/client/components/v-load-more.js 798 B
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 697 B
./frontend/.nuxt/dist/client/components/v-media-license.js 829 B
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 837 B
./frontend/.nuxt/dist/client/components/v-media-reuse.js 1.63 kB
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 1.62 kB
./frontend/.nuxt/dist/client/components/v-media-tag.js 434 B
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 439 B
./frontend/.nuxt/dist/client/components/v-modal.js 1.01 kB
./frontend/.nuxt/dist/client/components/v-modal.modern.js 996 B
./frontend/.nuxt/dist/client/components/v-no-results.js 757 B
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 755 B
./frontend/.nuxt/dist/client/components/v-radio.js 1.54 kB
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.5 kB
./frontend/.nuxt/dist/client/components/v-related-audio.js 1.27 kB
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 1.27 kB
./frontend/.nuxt/dist/client/components/v-related-images.js 3.24 kB
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 3.12 kB
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 978 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 980 B
./frontend/.nuxt/dist/client/components/v-row-layout.js 1.7 kB
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 1.71 kB
./frontend/.nuxt/dist/client/components/v-scroll-button.js 825 B
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 830 B
./frontend/.nuxt/dist/client/components/v-search-grid.js 5.74 kB
./frontend/.nuxt/dist/client/components/v-search-grid.modern.js 5.67 kB
./frontend/.nuxt/dist/client/components/v-search-results-title.js 600 B
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 605 B
./frontend/.nuxt/dist/client/components/v-search-type-radio.js 804 B
./frontend/.nuxt/dist/client/components/v-search-type-radio.modern.js 779 B
./frontend/.nuxt/dist/client/components/v-server-timeout.js 300 B
./frontend/.nuxt/dist/client/components/v-server-timeout.modern.js 303 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 1.01 kB
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 913 B
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.16 kB
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.16 kB
./frontend/.nuxt/dist/client/components/v-sources-table.js 15 kB
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 15 kB
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 306 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B
./frontend/.nuxt/dist/client/pages/about.js 1.4 kB
./frontend/.nuxt/dist/client/pages/about.modern.js 1.4 kB
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 5.65 kB
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 4.87 kB
./frontend/.nuxt/dist/client/pages/external-sources.js 1.56 kB
./frontend/.nuxt/dist/client/pages/external-sources.modern.js 1.57 kB
./frontend/.nuxt/dist/client/pages/feedback.js 1.34 kB
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.35 kB
./frontend/.nuxt/dist/client/pages/image/_id/index.js 6.02 kB
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 5.17 kB
./frontend/.nuxt/dist/client/pages/image/_id/report.js 1.27 kB
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 4.26 kB
./frontend/.nuxt/dist/client/pages/index.js 7.27 kB
./frontend/.nuxt/dist/client/pages/index.modern.js 7.21 kB
./frontend/.nuxt/dist/client/pages/preferences.js 1.32 kB
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.32 kB
./frontend/.nuxt/dist/client/pages/privacy.js 1.01 kB
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.02 kB
./frontend/.nuxt/dist/client/pages/search-help.js 1.6 kB
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.58 kB
./frontend/.nuxt/dist/client/pages/search.js 2.2 kB
./frontend/.nuxt/dist/client/pages/search.modern.js 2.05 kB
./frontend/.nuxt/dist/client/pages/search/audio.js 3.59 kB
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 3.51 kB
./frontend/.nuxt/dist/client/pages/search/image.js 2.84 kB
./frontend/.nuxt/dist/client/pages/search/image.modern.js 2.73 kB
./frontend/.nuxt/dist/client/pages/search/index.js 444 B
./frontend/.nuxt/dist/client/pages/search/index.modern.js 448 B
./frontend/.nuxt/dist/client/pages/search/model-3d.js 243 B
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 246 B
./frontend/.nuxt/dist/client/pages/search/search-page.types.js 266 B
./frontend/.nuxt/dist/client/pages/search/search-page.types.modern.js 271 B
./frontend/.nuxt/dist/client/pages/search/video.js 240 B
./frontend/.nuxt/dist/client/pages/search/video.modern.js 244 B
./frontend/.nuxt/dist/client/pages/sources.js 1.57 kB
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.57 kB
./frontend/.nuxt/dist/client/runtime.js 2.72 kB
./frontend/.nuxt/dist/client/runtime.modern.js 2.73 kB
./frontend/.nuxt/dist/client/vendors/app.js 64.1 kB
./frontend/.nuxt/dist/client/vendors/app.modern.js 63.3 kB

compressed-size-action

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Full-stack documentation: https://docs.openverse.org/_preview/1131

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhruvkb dhruvkb merged commit 5ae5b7f into main Apr 4, 2023
@dhruvkb dhruvkb deleted the fix_missing_info_slack_report branch April 4, 2023 15:08
obulat added a commit that referenced this pull request Apr 5, 2023
* Fix issues in the workflow simplifications of #1054 (#1058)

* Retry `up` recipe in case port is occupied (#990)

* Fix typo in docs building on `main` (#1067)

* Restore Django Admin views (#1065)

* Update other references of media count to 700 million (#1098)

* Dispatch workflows instead of regular reuse to show deployment runs (#1034)

* Use label.yml to determine required labels (#1063)

Co-authored-by: Dhruv Bhanushali <hi@dhruvkb.dev>

* Add `GITHUB_TOKEN` to GitHub CLI step (#1103)

* Pass actor for staging deploys with the `-f` flag (#1104)

* Bump ipython from 8.11.0 to 8.12.0 in /api (#1113)

Bumps [ipython](https://github.com/ipython/ipython) from 8.11.0 to 8.12.0.
- [Release notes](https://github.com/ipython/ipython/releases)
- [Commits](ipython/ipython@8.11.0...8.12.0)

---
updated-dependencies:
- dependency-name: ipython
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Absorb `actionlint` into pre-commit (#1028)

Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>

* Bump orjson from 3.8.8 to 3.8.9 in /api (#1114)

Bumps [orjson](https://github.com/ijl/orjson) from 3.8.8 to 3.8.9.
- [Release notes](https://github.com/ijl/orjson/releases)
- [Changelog](https://github.com/ijl/orjson/blob/master/CHANGELOG.md)
- [Commits](ijl/orjson@3.8.8...3.8.9)

---
updated-dependencies:
- dependency-name: orjson
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add Sentry to the ingestion server (#1106)

* Add a wait to filter button test to fix CI (#1124)

* Bump boto3 from 1.26.100 to 1.26.104 in /ingestion_server (#1110)

* Bump sentry-sdk from 1.17.0 to 1.18.0 in /api (#1112)

* Bump pillow from 9.4.0 to 9.5.0 in /api (#1115)

* Update redis Docker tag to v4.0.14 (#1109)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* 🔄 synced file(s) with WordPress/openverse-infrastructure (#1127)

Co-authored-by: openverse-bot <null>

* Update other references of media count to 700 million (#1100)

* Fix prod deployment workflow dispatch call (#1117)

* Add a Slack notification job to the CI + CD workflow (#1066)

* Fix types in VFilters and VContentReport (#1030)

* Move the svgs for radiomark and check to components

* Add files to tsconfig and fix types

* Mock report service in the unit test

* Type svg?inline as vue Component

* Better License code type checking

* Update frontend/src/components/VFilters/VFilterChecklist.vue

* Revert unnecessary changes

* Update frontend/src/components/VFilters/VFilterChecklist.vue

Co-authored-by: Zack Krida <zackkrida@pm.me>

* Rename `ownValue` to `value_`

---------

Co-authored-by: Zack Krida <zackkrida@pm.me>

* Convert VPill and VItemGroup stories to mdx (#1092)

* Convert VPill story to MDX
* Convert VItemGroup story to mdx
* Fixing argTypes issue and fixing the headers

* Update ci to use github.token (#1123)

* Add `SLACK_WEBHOOK_TYPE` env var to reporting job (#1131)

* Add consent decision-making process documentation (#887)

* Prepare VButton for updates (#1002)

* Rename button sizes and apply some styles only to 'old' buttons

* Rename the snapshot tests to v-button-old

* Fix VTab focus style

* Small fixes (large-old, border, group/button)

* Revert VTab focus changes

Moved to a different PR

* Revert "Revert VTab focus changes"

This reverts commit ec9312d.

* Use only focus-visible for consistency

* Bump boto3 from 1.26.99 to 1.26.105 in /api (#1133)

Bumps [boto3](https://github.com/boto/boto3) from 1.26.99 to 1.26.105.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.26.99...1.26.105)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add more docs for Plausible and auto-initialise custom event names (#1122)

* Add more docs for Plausible and auto-initialise custom event names

* Update existing docs

* Add caveat that it is not necessary to run Plausible if not working on custom events

* Fix ToC

* Add new buttons variants and sizes (#1003)

* Add new VButton sizes and variants

* Add new Storybook tests

* Add border to transparent- buttons

* Update bordered and transparent buttons

* Update stories

* Update snapshots

* Remove pressed variants

* Add missing snapshots

* Fix transparent buttons

* Update paddings

In accordance with #860 (comment)

* Update snapshots

* Update frontend/src/components/VButton.vue

Co-authored-by: Zack Krida <zackkrida@pm.me>

---------

Co-authored-by: Zack Krida <zackkrida@pm.me>

* Pass `GITHUB_TOKEN` to deploy docs (#1134)

* Add context manager and join()

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Dhruv Bhanushali <hi@dhruvkb.dev>
Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com>
Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>
Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
Co-authored-by: Tomvth <50104959+Tomvth@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Adarsh Rawat <adarshrawat141@gmail.com>
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Openverse (Bot) <101814513+openverse-bot@users.noreply.github.com>
Co-authored-by: Zack Krida <zackkrida@pm.me>
Co-authored-by: Sepehr Rezaei <54465154+sepehrrezaei@users.noreply.github.com>
Co-authored-by: Sumit Kashyap <mr.sumitkrr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: api Related to the Django API 🧱 stack: frontend Related to the Nuxt frontend 🧱 stack: ingestion server Related to the ingestion/data refresh server 🧱 stack: mgmt Related to repo management and automations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants