Use HTTPS for rpc.pingomatic.com (Update Services)

[peterwilsoncc]

• Update schema.php for new sites, and try updating the unit test. - props @sabernhardt
• Add upgrade routine to set the scheme to https

Questions:

• Should sanitize_option be updated to force HTTPS? I decided against it to allow for site owners choosing not to. But I might be wrong.
• The upgrade services documentation includes alternative providers. rpc.twingly.com now uses HTTPS too, should that be upgraded too?

https://core.trac.wordpress.org/ticket/42007

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sabernhardt, peterwilsoncc, jorbin.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[aaronjorbin]

Should sanitize_option be updated to force HTTPS? I decided against it to allow for site owners choosing not to. But I might be wrong.

I agree with your decision here. It's also not necessary as long as the DB upgrade runs.

The upgrade services documentation includes alternative providers. rpc.twingly.com now uses HTTPS too, should that be upgraded too?

I like this idea and it seems like it's not something that needs to wait on this change. PR submitted for that update WordPress/Advanced-administration-handbook#401

[peterwilsoncc]

I've made the following changes:

• update rpc.twingly.com to use HTTPS too
• Ensure the $url has a trailing slash when doing the string comparison.

See notes below re: database version number convention during commit process.

[peterwilsoncc]

Committers: When doing the commit to trunk this should be changed to the commit number in which it will appear. IE latest commit + 1.

[peterwilsoncc]

As above.

[peterwilsoncc]

As above.

[github-actions]

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 60421
GitHub commit: 1228a1e

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.