-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Scripts: Fix code comment about extra scripts sourceURL #9794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a grammatical error in a code comment that explains why sourceURL comments are not printed when script concatenation is enabled.
- Corrects "may a concatenated script" to "may break concatenated scripts"
- Improves clarity by changing "multiple are joined" to "multiple scripts are joined"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Developed in #9794. Follow-up to [60719]. Props jonsurrell, tobiasbg. See #63887. git-svn-id: https://develop.svn.wordpress.org/trunk@60722 602fd350-edb4-49c9-b593-d223f7449a82
Merged in [60722]. |
Developed in WordPress/wordpress-develop#9794. Follow-up to [60719]. Props jonsurrell, tobiasbg. See #63887. Built from https://develop.svn.wordpress.org/trunk@60722 git-svn-id: https://core.svn.wordpress.org/trunk@60058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Developed in WordPress/wordpress-develop#9794. Follow-up to [60719]. Props jonsurrell, tobiasbg. See #63887. Built from https://develop.svn.wordpress.org/trunk@60722 git-svn-id: http://core.svn.wordpress.org/trunk@60058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Developed in WordPress#9794. Follow-up to [60719]. Props jonsurrell, tobiasbg. See #63887. git-svn-id: https://develop.svn.wordpress.org/trunk@60722 602fd350-edb4-49c9-b593-d223f7449a82
@TobiasBg noticed a typo in a code comment from [60719].
Trac ticket: https://core.trac.wordpress.org/ticket/63887
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.