Skip to content

Conversation

himanshupathak95
Copy link

@himanshupathak95 himanshupathak95 commented Sep 8, 2025

Trac ticket: https://core.trac.wordpress.org/ticket/16839

This PR fixes category and tag base sanitization in permalink settings to prevent 404 errors when bases contain spaces or special characters.

When users set a category base with spaces (e.g., "Foo Bar"), WordPress generates URLs like example.com/Foo%20Bar/category, which results in 404 errors because rewrite rules expect example.com/foo-bar/category.

This PR -

  • Sanitizes category_base and tag_base using sanitize_title_with_dashes()
  • Handles multiple path segments correctly (e.g., "Foo Bar/Sub" → "foo-bar/sub")
  • Maintains backward compatibility with existing slugified bases
  • Addresses Unicode character handling mentioned in the original ticket
  • Added unit tests covering input scenarios

Copy link

github-actions bot commented Sep 8, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@himanshupathak95 himanshupathak95 marked this pull request as ready for review September 9, 2025 09:26
Copy link

github-actions bot commented Sep 9, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props abcd95.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant