Skip to content

Administration: Sanitize category and tag base to prevent URL encoding issues in permalinks #9797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from
+40 −10
Open

Administration: Sanitize category and tag base to prevent URL encoding issues in permalinks #9797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2b8fd45
Administration: Sanitize category and tag base to prevent URL encodin…
himanshupathak95 Sep 8, 2025
581faf5
Tests: Add tests class for the options permalink settings
himanshupathak95 Sep 9, 2025
1896772
Tests: Setup the provider function
himanshupathak95 Sep 9, 2025
c121fb1
Fix Linting
himanshupathak95 Sep 9, 2025
3373eb1
Tests: Add test for category and tag base sanitization
himanshupathak95 Sep 9, 2025
a2f6c87
Tests: Test category sanitisation
himanshupathak95 Sep 9, 2025
c11b5c3
Fix Linting
himanshupathak95 Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/wp-admin/options-permalink.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,21 +126,15 @@
}

if ( isset( $_POST['category_base'] ) ) {
$category_base = $_POST['category_base'];

if ( ! empty( $category_base ) ) {
$category_base = $blog_prefix . preg_replace( '#/+#', '/', '/' . str_replace( '#', '', $category_base ) );
}
$category_base = ltrim( $_POST['category_base'], '/' );
$category_base = empty( $category_base ) ? '' : $blog_prefix . '/' . implode( '/', array_map( 'sanitize_title_with_dashes', preg_split( '|/+|', $category_base ) ) );

$wp_rewrite->set_category_base( $category_base );
}

if ( isset( $_POST['tag_base'] ) ) {
$tag_base = $_POST['tag_base'];

if ( ! empty( $tag_base ) ) {
$tag_base = $blog_prefix . preg_replace( '#/+#', '/', '/' . str_replace( '#', '', $tag_base ) );
}
$tag_base = ltrim( $_POST['tag_base'], '/' );
$tag_base = empty( $tag_base ) ? '' : $blog_prefix . '/' . implode( '/', array_map( 'sanitize_title_with_dashes', preg_split( '|/+|', $tag_base ) ) );

$wp_rewrite->set_tag_base( $tag_base );
}
Expand Down
36 changes: 36 additions & 0 deletions tests/phpunit/tests/admin/optionsPermalink.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<?php

/**
* Tests for wp-admin/options-permalink.php
*
* @group admin
* @group rewrite
*/
class Tests_Admin_OptionsPermalink extends WP_UnitTestCase {
/**
* Data provider for base sanitization tests.
*/
public function data_base_sanitization() {
return array(
array( 'Foo Bar', '/foo-bar' ),
array( 'Foo & Bar!', '/foo-bar' ),
array( 'Foo Bar/Baz Qux', '/foo-bar/baz-qux' ),
array( '', '' ),
array( '/Foo Bar', '/foo-bar' ),
array( 'Multiple/Slashes', '/multiple/slashes' ),
);
}

/**
* Test category and tag base sanitization.
*
* @ticket 16839
* @dataProvider data_base_sanitization
*/
public function test_base_sanitization( $input, $expected ) {
$base = ltrim( $input, '/' );
$result = empty( $base ) ? '' : '/' . implode( '/', array_map( 'sanitize_title_with_dashes', preg_split( '|/+|', $base ) ) );

$this->assertSame( $expected, $result );
}
}
Loading