Skip to content

Conversation

sydneyjodon-wk
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk commented Aug 8, 2025

We should set up gha-dart-oss so we can:

  • take advantage of shared workflows
  • use the publish workflow to auto-publish on merge 🎉

QA instructions

  • CI passes
  • All steps previously run in CI are still running even if some of them are in the shared jobs now
  • When this merges, follow along to make sure the package actually publishes

checks:
uses: Workiva/gha-dart-oss/.github/workflows/checks.yaml@v0.1.11
with:
format-check: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently we weren't previously checking formatting? I can turn it on and run format if we would like

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mm fun. I say we hold off on that for now

@sydneyjodon-wk sydneyjodon-wk marked this pull request as ready for review August 8, 2025 23:05
additional-checks: |
no_entrypoint_imports

unit-tests:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these jobs are renamed, I'll update Rosie before we merge to check for the renamed versions of the checks

@btr-rmconsole-3 btr-rmconsole-3 bot changed the title Set up gha-dart-oss FED-4062 Set up gha-dart-oss Aug 11, 2025
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@sydneyjodon-wk
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@btr-rmconsole-1 btr-rmconsole-1 bot merged commit 0ffd58b into master Aug 25, 2025
12 checks passed
@btr-rmconsole-1 btr-rmconsole-1 bot deleted the use-gha-dart-oss branch August 25, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants