-
Notifications
You must be signed in to change notification settings - Fork 16
FED-4062 Set up gha-dart-oss #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
checks: | ||
uses: Workiva/gha-dart-oss/.github/workflows/checks.yaml@v0.1.11 | ||
with: | ||
format-check: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently we weren't previously checking formatting? I can turn it on and run format if we would like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mm fun. I say we hold off on that for now
additional-checks: | | ||
no_entrypoint_imports | ||
|
||
unit-tests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these jobs are renamed, I'll update Rosie before we merge to check for the renamed versions of the checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
We should set up gha-dart-oss so we can:
QA instructions