-
Notifications
You must be signed in to change notification settings - Fork 16
FED-4062 Set up gha-dart-oss #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1d21d32
Update to use gha-dart-oss
sydneyjodon-wk ce025ca
Update changelog
sydneyjodon-wk 741ccda
Turn off formatting
sydneyjodon-wk 4386d5b
Update release name to "Unreleased"
sydneyjodon-wk 093d132
Add Testing and Checks Completed step
sydneyjodon-wk 77cbf2c
Update runner
sydneyjodon-wk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
name: CI | ||
|
||
on: | ||
push: | ||
branches: | ||
- 'master' | ||
- 'test_consume_*' | ||
pull_request: | ||
branches: | ||
- '**' | ||
|
||
jobs: | ||
build: | ||
uses: Workiva/gha-dart-oss/.github/workflows/build.yaml@v0.1.11 | ||
|
||
checks: | ||
uses: Workiva/gha-dart-oss/.github/workflows/checks.yaml@v0.1.11 | ||
with: | ||
format-check: false | ||
additional-checks: | | ||
no_entrypoint_imports | ||
|
||
unit-tests: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since these jobs are renamed, I'll update Rosie before we merge to check for the renamed versions of the checks |
||
uses: Workiva/gha-dart-oss/.github/workflows/test-unit.yaml@v0.1.11 | ||
|
||
testing-and-checks-complete: | ||
name: Testing and Checks Completed | ||
needs: [ build, checks, unit-tests ] | ||
if: ${{ !cancelled() && github.event_name == 'pull_request' || github.ref_type == 'tag' }} | ||
runs-on: ubuntu-latest | ||
steps: | ||
- run: | | ||
if [ "${{ needs.checks.result }}" == "failure" ]; then | ||
echo "Some checks have failed. Please fix the issues and try again." | ||
exit 1 | ||
fi | ||
echo 'All Testing and checks have completed.' |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
name: Publish | ||
|
||
on: | ||
push: | ||
tags: | ||
- '[0-9]+.[0-9]+.[0-9]+' | ||
|
||
permissions: | ||
contents: write | ||
id-token: write | ||
pull-requests: write | ||
|
||
jobs: | ||
publish: | ||
uses: Workiva/gha-dart-oss/.github/workflows/publish.yaml@v0.1.11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently we weren't previously checking formatting? I can turn it on and run format if we would like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mm fun. I say we hold off on that for now