Initial implementation #2
Conversation
RavenNumber of Findings: 0 |
…e it easier to follow
| - pub run dart_dev test | ||
|
|
||
| after_script: | ||
| - pub run dart_dev docs --no-open |
There was a problem hiding this comment.
I'm not sure why you put this in after_script.
(I'm also not sure why after_script even exists)
There was a problem hiding this comment.
I don't know why I did either, I was just following a CP library since I am hoping to hand it off to them :)
| @@ -0,0 +1,21 @@ | |||
| name: platform_detect | |||
| description: A lightweight library for detecting the running browser and OS | |||
| version: 0.0.1 | |||
There was a problem hiding this comment.
Probably an opinion, but I think this should be 0.1.0
There was a problem hiding this comment.
any objection to 1.0.0 instead?
There was a problem hiding this comment.
I was planning to merge this as 0.0.1 and then make a tag PR with Rosie to release 1.0.0
|
+1 I have nothing but nits. Let me know if you change anything and want a re-review. |
|
+1 |
Last updated on Friday, October 07 01:52 PM CST |
|
QA review can be found here: https://jira.atl.workiva.net/browse/RM-15752 |
@maxwellpeterson-wf @evanweible-wf @trentgrover-wf @dustyholmes-wf the owner of browser_detect isn't responding on GitHub or email so decided to spin up our own repo that can do what we want. Would love to see this moved to OSS once CP takes ownership :)