Skip to content

Conversation

rmconsole-wf
Copy link

Pulls Included in Release:

Requested by: travissanderson-wf

@aviary2-wf
Copy link

Raven

Number of Findings: 0

@rmconsole-wf
Copy link
Author

rmconsole-wf commented Oct 7, 2016

  • QA Review (a1d8110 - may be done on the release of a tier one repo)

    When this pull is merged I will use the following information:
    Version: platform_detect 1.0.0
    Release Ticket(s): CP-2751
    
    This pull is considered the release of platform_detect 1.0.0 
    The options defined for this repo will be carried out
    


Last updated on Friday, October 07 04:07 PM CST

@travissanderson-wf
Copy link
Contributor

@evanweible-wf @maxwellpeterson-wf @dustyholmes-wf tagging 1.0.0 - @dustyholmes-wf would you mind trying this out in w_table?

@codecov-wf
Copy link

Current coverage is 87.87% (diff: 100%)

Merging #4 into master will not change coverage

@@             master         #4   diff @@
==========================================
  Files             2          2          
  Lines            66         66          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits             58         58          
  Misses            8          8          
  Partials          0          0          

Sunburst

Diff Coverage File Path

Powered by Codecov. Last update decb7d8...a1d8110

@travissanderson-wf
Copy link
Contributor

truss also depends on browser_detect if you guys want to try switching over to this https://github.com/Workiva/truss/blob/master/pubspec.yaml#L15

@rmconsole2-wf rmconsole2-wf changed the title Release platform_detect 1.0.0 CP-2751 Release platform_detect 1.0.0 Oct 7, 2016
@dustyholmes-wf
Copy link

+1 in my testing this works well with w_table.

@maxwellpeterson-wf
Copy link
Member

+1

@travissanderson-wf travissanderson-wf merged commit 2a2b329 into master Oct 7, 2016
@rmconsole-wf
Copy link
Author

QA review can be found here: https://jira.atl.workiva.net/browse/RM-15752

@travissanderson-wf travissanderson-wf deleted the version-bump-platform_detect-1-0-0 branch November 7, 2016 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants