RED-1097: Added initial aviary.yaml file. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 1
As a result of the finding(s) listed above, a security review is required for this pull request. |
|
|
+1 |
|
security +1 |
aviary.yaml
Outdated
| version: 1 | ||
|
|
||
| exclude: | ||
| - test?/ |
There was a problem hiding this comment.
@mairaemperley-wf Just noticed this - it should be either tests?/ or test/
test?/ will match both test/ and tes/
There was a problem hiding this comment.
Good catch! Fixed.
Current coverage is 87.87% (diff: 100%)@@ master #5 diff @@
==========================================
Files 2 2
Lines 66 66
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 58 58
Misses 8 8
Partials 0 0
|
|
+1 |
|
@ericanders-wf do you want to update your security review for the latest commit? |
|
+1 security |
|
QA may be done on release of this |
|
QA review can be found here: https://jira.atl.workiva.net/browse/RM-15979 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding an initial aviary.yaml file to support Aviary/Raven scanning of this repository. Currently the file excludes the test, example, and functional_test directories from global keyword scanning, but adds no explicitly watched files or functions.
FYI @travissanderson-wf - If you know of any areas of the application that might be considered sensitive, please let me know or add them to the config directly. If you have any questions about this process please reach out in the "Infosec Forum" hipchat room.
@infosec-wf