Skip to content

Conversation

rmconsole-wf
Copy link

Pulls Included in Release:

Requested by: @travissanderson-wf

Diff Between Last Tag and Proposed Release: 1.0.0...version-bump-platform_detect-1-0-1
Diff Between Last Tag and New Tag: 1.0.0...1.0.1

@aviary2-wf
Copy link

Raven

Number of Findings: 0

@rmconsole-wf rmconsole-wf changed the title Release platform_detect 1.0.1 CP-2759 Release platform_detect 1.0.1 Oct 21, 2016
@rmconsole-wf
Copy link
Author

rmconsole-wf commented Oct 21, 2016

    When this pull is merged I will use the following information:
    Version: platform_detect 1.0.1
    Release Ticket(s): CP-2759

    This pull is considered the release of platform_detect 1.0.1 
    The options defined for this repo will be carried out


Last updated on Monday, October 24 10:50 AM CST

@travissanderson-wf
Copy link
Contributor

@markrusciano-wf please p10 with your PR

@travissanderson-wf
Copy link
Contributor

+1

@codecov-wf
Copy link

Current coverage is 87.87% (diff: 100%)

Merging #7 into master will not change coverage

@@             master         #7   diff @@
==========================================
  Files             2          2          
  Lines            66         66          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits             58         58          
  Misses            8          8          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 90e0bfe...f6c73cd

1 similar comment
@codecov-wf
Copy link

Current coverage is 87.87% (diff: 100%)

Merging #7 into master will not change coverage

@@             master         #7   diff @@
==========================================
  Files             2          2          
  Lines            66         66          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits             58         58          
  Misses            8          8          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 90e0bfe...f6c73cd

@markrusciano-wf
Copy link
Contributor

markrusciano-wf commented Oct 24, 2016

+10

  • Tested in Workiva/datatables#1153
  • Acceptance Criteria
    • Able to mock Browser object
  • Regression testing
    • Platform detect detects platforms

@travissanderson-wf travissanderson-wf merged commit 6ab96fe into master Oct 24, 2016
@travissanderson-wf travissanderson-wf deleted the version-bump-platform_detect-1-0-1 branch November 7, 2016 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants