DT-5901 Export Browser and OperatingSystem classes #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.87% (diff: 100%)@@ master #6 diff @@
==========================================
Files 2 2
Lines 66 66
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 58 58
Misses 8 8
Partials 0 0
|
markrusciano-wf
changed the title
markrusciano-wf
force-pushed
the
expose-classes
branch
from
1fb69ca to
f8d60a6
Compare
|
+1 |
|
@markrusciano-wf But why do you need these objects? |
|
he wants to create fake browser objects for unit tests |
|
+1 |
|
I have nothing to display, for a full report click here |
|
QA may be done on release of this |
|
QA review can be found here: https://jira.atl.workiva.net/browse/RM-15979 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / Feature
browserandoperatingSystemgetters return objects of types that are not exported.Solution
Export
BrowserandOperatingSystemclasses.What To Test
Attempt to use
BrowserandOperatingSystemclasses in an app which consumesplatform-detectReviewers
@travissanderson-wf @dustyholmes-wf