FEA-3404: export SymbolGenerator #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
| 'scip-dart', | ||
| _getPackage(element), | ||
| _getDescriptor(element), | ||
| descriptor, |
There was a problem hiding this comment.
we were unnecessary generating the descriptor twice, for every symbol (see line 43) this cleans that up
todbachman-wf
previously approved these changes
Mar 4, 2024
|
QA +1
🚀 @Workiva/release-management-p 🚢 |
todbachman-wf
approved these changes
Mar 4, 2024
|
QA +1
🚀 @Workiva/release-management-p 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many usages for symbol representations of dart element types. Not all of these usages fall into the category of the raw indexing and outputting of an indexed repo
This pr exports an internal class:
SymbolGenerator, which can be used to convert dart analyzer element types in their correlating scip symbol, allowing for unique and innovative implementation for generating these scip symbols