Skip to content

FEA-3404: export SymbolGenerator #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 4, 2024
Merged

FEA-3404: export SymbolGenerator #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0deb947
export symbol generator
matthewnitschke-wk Mar 4, 2024
3c971de
different file export
matthewnitschke-wk Mar 4, 2024
ddc25ff
updated documentation for the symbol generator internals
matthewnitschke-wk Mar 4, 2024
32eca35
fmt
matthewnitschke-wk Mar 4, 2024
e1ffe8d
upload artifacts in dockerfile
matthewnitschke-wk Mar 4, 2024
d6e8a27
run pub get
matthewnitschke-wk Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
FROM scratch
FROM drydock-prod.workiva.net/workiva/dart2_base_image:2
ADD pubspec.yaml pubspec.yaml
RUN dart pub get
FROM scratch
4 changes: 2 additions & 2 deletions lib/src/symbol_generator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class SymbolGenerator {
/// that should be used for the element. If no element is found,
/// [_localElementIndex] should be used to generate one.
///
/// Use []
/// Use [_localSymbolFor] to generate new local symbols
Map<Element, String> _localElementRegistry = {};

SymbolGenerator(this._packageConfig, this._pubspec);
Expand Down Expand Up @@ -47,7 +47,7 @@ class SymbolGenerator {
return [
'scip-dart',
_getPackage(element),
_getDescriptor(element),
descriptor,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we were unnecessary generating the descriptor twice, for every symbol (see line 43) this cleans that up

].join(' ');
}

Expand Down
1 change: 1 addition & 0 deletions lib/symbol_generator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export 'src/symbol_generator.dart' show SymbolGenerator;