Skip to content

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Mar 6, 2023

FEA-1507

Issue Status

Closes #11

scip_dart ./path/to/root -p ./lib -p ./test -p ./bin

@rmconsole-wf
Copy link

rmconsole-wf commented Mar 6, 2023

Merge Requirements Met ✅

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

General Information

Ticket(s):

Code Review(s): #17
Release Image Tags:

  • drydock.workiva.net/workiva/scip-dart:4356852
  • drydock.workiva.net/workiva/scip-dart:pr-17

Reviewers: evanweible-wf, matthewnitschke-wk

Additional Information

Watchlist Notifications: None

	When this pull is merged I will add it to the following release:
	Version: scip-dart 1.0.4
	Release Ticket(s): RM-183271


Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Thursday, March 09 10:27 AM CST

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@matthewnitschke-wk matthewnitschke-wk marked this pull request as ready for review March 6, 2023 18:52
@matthewnitschke-wk matthewnitschke-wk changed the title Added support for indexing paths Added support for indexing test and bin Mar 6, 2023
@bender-wk bender-wk changed the title Added support for indexing test and bin FEA-1507: Added support for indexing test and bin Mar 6, 2023
@matthewnitschke-wk matthewnitschke-wk requested a review from a team March 6, 2023 18:54
@matthewnitschke-wk
Copy link
Contributor Author

QA +1

  • CI does indeed pass

🚀 @Workiva/release-management-p 🚢

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index bin and test directories
5 participants