-
Notifications
You must be signed in to change notification settings - Fork 2
FEA-1616: Index Comment References #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge Requirements Met ✅Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment. General InformationTicket(s): Code Review(s): #27
Reviewers: todbachman-wf, matthewnitschke-wk Additional InformationWatchlist Notifications: None
Note: This is a shortened report. Click here to view Rosie's full evaluation. |
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
QA +1 Verified scip snapshot diff is what we expect and is good to go |
🚀 @Workiva/release-management-p 🚢 |
@matthewnitschke-wk I will not merge this because:
|
@matthewnitschke-wk I will not merge this because:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
FEA-1616
Comment
ast nodes used to break scip indexing, but it appears that this is no longer the case, and the correct symbols are generated for all references within commentsRemoved the edge case that skipped any ast symbols within comments, so all references in doc comments are correctly indexed
Closes #26