Skip to content

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Apr 4, 2023

FEA-1616

Issue Status

Comment ast nodes used to break scip indexing, but it appears that this is no longer the case, and the correct symbols are generated for all references within comments

Removed the edge case that skipped any ast symbols within comments, so all references in doc comments are correctly indexed

Closes #26

@rmconsole-wf
Copy link

rmconsole-wf commented Apr 4, 2023

Merge Requirements Met ✅

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

General Information

Ticket(s):

Code Review(s): #27
Release Image Tags:

  • drydock.workiva.net/workiva/scip-dart:4433734
  • drydock.workiva.net/workiva/scip-dart:pr-27

Reviewers: todbachman-wf, matthewnitschke-wk

Additional Information

Watchlist Notifications: None

	When this pull is merged I will add it to the following release:
	Version: scip-dart 1.0.5
	Release Ticket(s): RM-186585


Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Tuesday, April 04 05:30 PM CST

@matthewnitschke-wk matthewnitschke-wk changed the title index comment references Index Comment References Apr 4, 2023
@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@matthewnitschke-wk matthewnitschke-wk marked this pull request as ready for review April 4, 2023 04:20
todbachman-wf
todbachman-wf previously approved these changes Apr 4, 2023
@bender-wk bender-wk changed the title Index Comment References FEA-1616: Index Comment References Apr 4, 2023
@matthewnitschke-wk
Copy link
Contributor Author

QA +1

Verified scip snapshot diff is what we expect and is good to go

@matthewnitschke-wk
Copy link
Contributor Author

🚀 @Workiva/release-management-p 🚢

@rmconsole-wf
Copy link

@matthewnitschke-wk I will not merge this because:

  • 'Dependency Scan Clean' is False
  • dependencies not scanned

@matthewnitschke-wk
Copy link
Contributor Author

@rmconsole-wf

@rmconsole-wf
Copy link

@matthewnitschke-wk I will not merge this because:

  • 'All commits reviewed' is False
  • 'Dependency Scan Clean' is False
  • dependencies not scanned
  • Last commit does not have code review

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index symbols within comments
5 participants