Skip to content

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented May 29, 2023

Adds support for a --version/-v flag, correctly populates version in ToolInfo which is present in the resulting scip bindings

Closes #43

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

toolInfo: ToolInfo(
name: 'scip-dart',
version: '0.0.1',
name: 'scip_dart',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while the repo is called scip-dart, due to pub rules, the package is called scip_dart

Officially the name should be scip_dart, so reflect this in the tool info

@matthewnitschke-wk
Copy link
Contributor Author

Closing in favor of: #65

Needing to re-run the builder during release process is more complex than the release process just bumping the version manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correctly populate version in ToolInfo
4 participants