Skip to content

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Jun 29, 2023

FEA-2108

Issue Status

Adds support for a --version flag and correctly populates ToolInfo as per the official scip spec.


The easier implementation than #45,

Initial pass will rely on release process to bump version.dart to the correct version, we can later consider what this looks like fully within the package without external processes

Once merged, the release process will be updated to automatically bump const scipDartVersion = '1.1.1'; to the latest version

Closes #43

@matthewnitschke-wk matthewnitschke-wk changed the title Populated ToolInfo version Populated ToolInfo Version Jun 29, 2023
@matthewnitschke-wk matthewnitschke-wk marked this pull request as ready for review June 29, 2023 15:26
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@matthewnitschke-wk matthewnitschke-wk changed the title Populated ToolInfo Version Populate ToolInfo Version Jun 29, 2023
@bender-wk bender-wk changed the title Populate ToolInfo Version FEA-2108: Populate ToolInfo Version Jun 29, 2023
@matthewnitschke-wk matthewnitschke-wk requested a review from a team June 29, 2023 15:55
@matthewnitschke-wk
Copy link
Contributor Author

QA +1

  • CI does indeed pass

🚀 @Workiva/release-management-p 🚢

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correctly populate version in ToolInfo
5 participants