Skip to content

Conversation

@xuliangTang
Copy link
Contributor

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs update
  • Code style update
  • Refactor
  • Performance Improvements
  • Build-related changes
  • Other, please describe:

Does this PR introduce a BREAKING CHANGE? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • Make sure you are requesting to pull a feature/bugfix branch (right side). Don't request master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop branch.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Description

Please describe your pull request.

❤️ Thank you!

@xuliangTang xuliangTang requested a review from a team as a code owner March 28, 2022 03:44
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #7 (f3d1f93) into main (ead6776) will decrease coverage by 1.29%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main       #7      +/-   ##
============================================
- Coverage     61.01%   59.72%   -1.30%     
- Complexity       18       20       +2     
============================================
  Files             4        4              
  Lines            59       72      +13     
============================================
+ Hits             36       43       +7     
- Misses           23       29       +6     
Impacted Files Coverage Δ
src/Redis.php 71.18% <50.00%> (-4.91%) ⬇️

@ygnice ygnice requested a review from Teakowa March 28, 2022 03:51
@ygnice ygnice merged commit f4fa8ec into main Mar 28, 2022
@Teakowa Teakowa deleted the feat/hash branch March 30, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants