Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #312

Merged
merged 11 commits into from
Dec 16, 2021
Merged

Update documentation #312

merged 11 commits into from
Dec 16, 2021

Conversation

thisac
Copy link
Contributor

@thisac thisac commented Dec 15, 2021

Context:
Some parts of the documentation were not consistent.

Description of the Change:

  • Fixes a few inconsistencies in the module docs.
  • Imports all submodules in __init__.py.

@thisac thisac requested review from josh146 and sduquemesa and removed request for sduquemesa December 15, 2021 19:37
@thisac thisac self-assigned this Dec 15, 2021
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #312 (0e3119b) into master (cc53d39) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #312   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         1561      1568    +7     
=========================================
+ Hits          1561      1568    +7     
Impacted Files Coverage Δ
thewalrus/_hafnian.py 100.00% <ø> (ø)
thewalrus/_permanent.py 100.00% <ø> (ø)
thewalrus/charpoly.py 100.00% <ø> (ø)
thewalrus/csamples.py 100.00% <ø> (ø)
thewalrus/decompositions.py 100.00% <ø> (ø)
thewalrus/fock_gradients.py 100.00% <ø> (ø)
thewalrus/quantum/__init__.py 100.00% <ø> (ø)
thewalrus/quantum/fock_tensors.py 100.00% <ø> (ø)
thewalrus/random.py 100.00% <ø> (ø)
thewalrus/reference.py 100.00% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc53d39...0e3119b. Read the comment docs.

@thisac thisac requested a review from nquesada December 15, 2021 19:52
thewalrus/_hafnian.py Outdated Show resolved Hide resolved
thewalrus/_hafnian.py Outdated Show resolved Hide resolved
thewalrus/_hafnian.py Outdated Show resolved Hide resolved
thewalrus/_hafnian.py Outdated Show resolved Hide resolved
thewalrus/_hafnian.py Outdated Show resolved Hide resolved
thisac and others added 2 commits December 15, 2021 15:45
Co-authored-by: Nicolas Quesada <991946+nquesada@users.noreply.github.com>
docs/code.rst Outdated
@@ -12,6 +12,10 @@ Python API

* The :mod:`thewalrus.symplectic` submodule provides access to a convenient set of symplectic matrices and utility functions to manipulate them

* The :mod:`thewalrus.decompositions` submodule provides access to common shared matrix decompositions used to perform gate decompositions

* The :mod:`thewalrus.labudde` submodule provides access to La Budde's algorithm to calculate the characteristic polynomials of matrices
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we simply import the labudde functions top level?

Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Theo! Don't forget to update the changelog

docs/code.rst Show resolved Hide resolved
docs/code.rst Outdated Show resolved Hide resolved
thewalrus/decompositions.py Show resolved Hide resolved
@@ -15,13 +15,16 @@
Fock gradients of Gaussian gates
================================

**Module name:** :mod:`thewalrus.fock_gradients`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out-of-scope thought: we should rename this module to simply thewalrus.fock (although this would be a breaking change for SF).

The reason being, I was helping a user use TW, and both the user and myself completely overlooked this module, as we assumed it only provided gradients! Whereas the focus of this module is more Fock representations (of which gradients are included)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable, I'd say. 👍

thewalrus/labudde.py Outdated Show resolved Hide resolved
thewalrus/labudde.py Outdated Show resolved Hide resolved
@thisac thisac merged commit e531787 into master Dec 16, 2021
@thisac thisac deleted the update-documentation branch December 16, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants