[Actions] Downgrade to Java 17 #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, it looks like even the latest Gradle (8.4 currently) does not support running itself (but it does building other applications) using Java 21. Downgrading to Java 17 to keep things simple.
Since it's not used.
|
Also disable pip caching in scoring_criteria.yml. |
|
It looks like it passed during #30 because GH pulled in |
eddieh-xlnx
added a commit
that referenced
this pull request
May 29, 2025
This reverts commit 2a11b91. Signed-off-by: Eddie Hung <eddie.hung@amd.com>
eddieh-xlnx
added a commit
that referenced
this pull request
May 29, 2025
This reverts commit 2a11b91. Signed-off-by: Eddie Hung <eddie.hung@amd.com>
eddieh-xlnx
added a commit
that referenced
this pull request
Jun 3, 2025
* Revert "[Actions] Downgrade to Java 17 (#41)" This reverts commit 2a11b91. Signed-off-by: Eddie Hung <eddie.hung@amd.com> * Update RapidWright to v2024.2.3 Signed-off-by: Eddie Hung <eddie.hung@amd.com> * Update gradle to 8.14 Signed-off-by: Eddie Hung <eddie.hung@amd.com> * Try bigger nxroute area Signed-off-by: Eddie Hung <eddie.hung@amd.com> * Grow nxroute area some more Signed-off-by: Eddie Hung <eddie.hung@amd.com> * Move RapidWright to 'rwroute_always_target' branch Signed-off-by: Eddie Hung <eddie.hung@amd.com> * Re-set RapidWright to rwroute_always_target Signed-off-by: Eddie Hung <eddie.hung@amd.com> * Pull back nxroute region Signed-off-by: Eddie Hung <eddie.hung@amd.com> * Move RapidWright back to master Signed-off-by: Eddie Hung <eddie.hung@amd.com> * Use 'python3 -m pip' instead Signed-off-by: Eddie Hung <eddie.hung@amd.com> --------- Signed-off-by: Eddie Hung <eddie.hung@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, it looks like even the latest Gradle (8.4 currently) does not support running itself (but it can build other applications) using Java 21.
Downgrading to Java 17 to keep things simple.