Skip to content

XinRefinement v1.6.3 — e.s.d. report value column fix and low-risk audit fixes

Choose a tag to compare

@XinProf XinProf released this 11 Nov 07:46
· 22 commits to master since this release

XinRefinement v1.6.3

Fix: e.s.d. report "Value" column (A11)

  • Root cause: EsdResult did not store the true parameter values, so the "Value" column in text/JSON reports was incorrectly filled with e.s.d.
  • Fix: added a values field (concat(x_final, c), in strict same order as labels); the text table now uses zip(labels, values, esd), and JSON gains values. The e.s.d. / covariance / correlation / content e.s.d. computation paths are all untouched.

Low-risk audit fixes (F01–F06, from the previous round of global code review)

  • F01: the phase display name name_mineral was lost during structure_with_cell / xyz step rebuild → display name degradation
  • F02: legacy _unpack rebuild of ProfileParams omitted size_strain
  • F03: _solve_raw in api.report() omitted refine_po, inconsistent with api.refine()
  • F04: .xinr/.xinm pattern serialization %.10g → %.17g, bit-for-bit identical on save/reopen
  • F05: CLI -o now auto-creates a missing parent directory; to_report texture completion for model/degree/coeffs
  • F06: step buttons still showed Chinese after a language switch → now uses tr(f'step.{key}')

Tests

  • De-flaked the cancellation run test: the cancellation predicate changed from an absolute wall clock >0.15s to a residual checkpoint count, asserting the real contract (cancellation is not recorded as failed, and the unpromised precondition "at least one step completed" is no longer appended)

UI

  • Splash screen shrunk to 800×600, and the version number text removed

Verification

  • Full regression: 547 passed / 0 failed / 6 skipped (the 6 skips are due to environment tier differences — missing COD archive / gemmi / xinmatch on this machine — not a regression)
  • golden CLI Rwp = 3.4074156640940005 bit-for-bit unchanged
  • installer size 75.0 MB, sha256 184695ec1238773e1aedc7547e5b4072bdacadfd52025c968fe77839e3456ae4