Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the Yoast SEO Breadcrumbs panel from the Customizer #21360

Merged
merged 4 commits into from
May 7, 2024

Conversation

enricobattocchi
Copy link
Member

@enricobattocchi enricobattocchi commented May 2, 2024

Context

Summary

This PR can be summarized in the following changelog entry:

  • Removes the Yoast SEO Breadcrumbs panel from the Customizer to improve compatibility with block-based themes. Users can always change the options for the breadcrumbs under Yoast SEO > Settings > Advanced > Breadcrumbs.
  • Deprecates the WPSEO_Customizer class.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Install and activate with a block-based theme and no other plugin active
  • Check that you don't see a Customizer link under Appearance anymore

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #21342

@enricobattocchi enricobattocchi added UI change PRs that result in a change in the UI changelog: other Needs to be included in the 'Other' category in the changelog labels May 2, 2024
@enricobattocchi enricobattocchi force-pushed the deprecate-wpseo-customizer branch from 2323925 to 689fc1a Compare May 2, 2024 13:45
@enricobattocchi enricobattocchi force-pushed the deprecate-wpseo-customizer branch from a847f1d to 72c241e Compare May 3, 2024 06:38
Copy link
Member

@igorschoester igorschoester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR && AT ✅

@igorschoester igorschoester added this to the 22.8 milestone May 7, 2024
@igorschoester igorschoester merged commit 640f7b1 into trunk May 7, 2024
23 checks passed
@igorschoester igorschoester deleted the deprecate-wpseo-customizer branch May 7, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: other Needs to be included in the 'Other' category in the changelog UI change PRs that result in a change in the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the Breadcrumbs settings from the customizer
2 participants