Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in pmgen #1298

Merged
merged 17 commits into from
Aug 20, 2019
Merged

Improvements in pmgen #1298

merged 17 commits into from
Aug 20, 2019

Conversation

cliffordwolf
Copy link
Collaborator

@cliffordwolf cliffordwolf commented Aug 15, 2019

This adds some improvements to pmgen for recursive patterns. It also includes a demo_reduce pass to demonstrate the new features. (Not sure if that should be included in the final PR.)

Simple test case for demo_reduce (test.v):

module test (input A, B, C, D, E, output X, Y, Z);
	assign X = (A & B) & (C & D & E);
	assign Y = (A | B | C | D) | E;
	assign Z = A ^ (B ^ C) ^ D ^ E;
endmodule

Run with yosys -p 'prep; simplemap;; demo_reduce; show' test.v.

Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Copy link
Collaborator

@eddiehung eddiehung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Document semioptional (is it only valid inside a subpattern?)
  • Add CHANGELOG entry

Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
@cliffordwolf cliffordwolf changed the title [WIP] Improvements in pmgen Improvements in pmgen Aug 16, 2019
@cliffordwolf cliffordwolf removed the request for review from daveshah1 August 16, 2019 12:25
@cliffordwolf
Copy link
Collaborator Author

Demo for the test case generator:

yosys -p 'test_pmgen -generate reduce; hierarchy -top pmtest_test_pmgen_pm_reduce_00099; test_pmgen -reduce_chain;; show'

cliffordwolf and others added 2 commits August 16, 2019 14:35
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Copy link
Collaborator

@eddiehung eddiehung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test that runs test_pmgen on a circuit?

passes/pmgen/test_pmgen.cc Show resolved Hide resolved
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
@cliffordwolf cliffordwolf merged commit ba71e4f into master Aug 20, 2019
@cliffordwolf cliffordwolf deleted the clifford/pmgen branch August 20, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants