-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements in pmgen #1298
Merged
Merged
Improvements in pmgen #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
cliffordwolf
force-pushed
the
clifford/pmgen
branch
from
August 15, 2019 16:37
98c6d6d
to
03f98d9
Compare
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
eddiehung
requested changes
Aug 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Document
semioptional
(is it only valid inside asubpattern
?) - Add CHANGELOG entry
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Demo for the test case generator:
|
Signed-off-by: Clifford Wolf <clifford@clifford.at>
eddiehung
reviewed
Aug 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a test that runs test_pmgen
on a circuit?
eddiehung
reviewed
Aug 16, 2019
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
Signed-off-by: Clifford Wolf <clifford@clifford.at>
eddiehung
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some improvements to pmgen for recursive patterns. It also includes a
demo_reduce
pass to demonstrate the new features. (Not sure if that should be included in the final PR.)Simple test case for
demo_reduce
(test.v
):Run with
yosys -p 'prep; simplemap;; demo_reduce; show' test.v
.