Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cxxrtl: don't emit invalid code on unconnected outputs. #4417

Merged
merged 2 commits into from
Jun 9, 2024
Merged

cxxrtl: don't emit invalid code on unconnected outputs. #4417

merged 2 commits into from
Jun 9, 2024

Conversation

kivikakk
Copy link
Contributor

Unconnected sync outputs cause dump_cell_sync to emit an invalid assignment in the instantiating module, namely value<0>() = …;.

Ensure the LHS is not empty before emitting.

@kivikakk kivikakk requested a review from whitequark as a code owner May 26, 2024 15:43
@kivikakk kivikakk mentioned this pull request Jun 7, 2024
Merged
whitequark
whitequark approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@whitequark whitequark merged commit 9f94ecf into YosysHQ:main Jun 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kivikakk @whitequark