ci(deploy): retry gcloud ssh connections if it fails
#5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behavior From time to time SSH connections to deployed VMs fails with the following error: `kex_exchange_identification: Connection closed by remote host` Expected behavior If the connection fails, attempt to reconnect once again (or multiple times) Solution Add the `ConnectionAttempts` and `ConnectTimeout` with 20 and 5 values respectively, which attempst to reconnect 19 more times every 5 seconds
gustavovalverde
added
C-bug
gustavovalverde
requested review from
dconnolly
and removed request for
a team
github-actions
bot
added
the
C-trivial
teor2345
added
C-trivial
teor2345
approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Thanks, this seems like it might work, I guess we have to merge to find out.
Next time we need to change these parameters, let's put the settings in one place using a SSH config file or workflow environmental variables?
That way we don't have to modify the workflow in 10 places for the same change.
Yeah, I think we should even see how to accomplish a DRY(er) approach on this workflows. |
Another thing we can do is move workflow and Docker scripts into |
gustavovalverde
added a commit
that referenced
this pull request
Oct 4, 2022
Previous behavior: From time to time SSH connections to deployed VMs fails with the following error: `kex_exchange_identification: Connection closed by remote host` This was still happening after implementing #5292 Excpected behavior: Ensure we're not creating SSH key pairs on the fly to improve our connections guarantees Solution: - Enable the Cloud Identity-Aware Proxy API in GCP - Create a firewall rule to enable connections from IAP - Grant the required IAM permissions to enable IAP TCP forwarding - Generate an SSH keys pair and set a private key as an input param - Set the GitHub Action SA to have authorized ssh connection to the VMs - Implement the `google-github-actions/ssh-compute` action to connect
5 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
* refactor(ssh): connect using `ssh-compute` action by Google Previous behavior: From time to time SSH connections to deployed VMs fails with the following error: `kex_exchange_identification: Connection closed by remote host` This was still happening after implementing #5292 Excpected behavior: Ensure we're not creating SSH key pairs on the fly to improve our connections guarantees Solution: - Enable the Cloud Identity-Aware Proxy API in GCP - Create a firewall rule to enable connections from IAP - Grant the required IAM permissions to enable IAP TCP forwarding - Generate an SSH keys pair and set a private key as an input param - Set the GitHub Action SA to have authorized ssh connection to the VMs - Implement the `google-github-actions/ssh-compute` action to connect * fix(ssh): id `compute-ssh` cannot be used more than once within the same scope * fix(ci): try to enclose commands to override parsing issues * tmp: remove ssh_args * fix(action): secrets must be inherited to be used * tmp: validate command enclosing fixes executin * fix(ssh): ssh_args are not implemented correctly * fix(ssh): login with the root user * fix(privelege): uso sudo with docker commands * tmp: add sudo * fix(ssh): use sudo for all docker commands * fix(ssh): add missing `sudo` commands * fix(ssh): get sync height from ssh stdout * fix(height): get the height correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior
From time to time SSH connections to deployed VMs fails with the following error:
kex_exchange_identification: Connection closed by remote hostExpected behavior
If the connection fails, attempt to reconnect once again (or multiple times)
Solution
Add the
ConnectionAttemptsandConnectTimeoutwith 20 and 5 values respectively, which attempst to reconnect 19 more times every 5 secondsReview
Anyone can review this
Reviewer Checklist
Follow Up Work
If this issue keeps raising, even after the retries, we might want to apply some best SSH practices for Google Cloud (which we might want to apply anyways) as stated here https://cloud.google.com/compute/docs/instances/connecting-advanced