worker: remove type checking on ServiceBinderSpec.worker #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…liance * extract class 'Index' into a dedicated 'index-generator' module dependency to allow mocking. * 100% coverage of IndexedQueue code
* modify argument invariants of valid service method call accordingly * add unit test for undefined args property
* simplify message handling in ServiceProxy * modify WorkerService to comply with ServiceProxy message format * update WorkerService unit tests accordingly
* refactor message-related interfaces * refactor proxy method * prune unused functions
…ingly * extract utility functions into common src/lib/utils.ts * improve managent of argument invariants * add ServiceProxy configuration options for dependency injection * add duck-type based type validation functions for Worker, IndexedQueue and IndexGenerator * remove generic type from IndexedQueue, not required for ServiceProxy implementation * modify handling of index conflict in IndexedQueue#push, allowing multiple attempts to push an entry into the queue with successive calls to push * remove IndexGenerator#undo, not required any longer * add IndexGenerator#value instead, only required for IndexGenerator testing * modify unit tests accordingly
* remove `worker` property from `opts` argument
* rename `path` argument to `worker`, which can now be a {string} or
{Worker}
* modify dependents accordingly, including README example
* add support for require() in worker script through `webworkify` * add unit tests to validate new use-case with webworkify * add webworkify section in README * rebase example code on `src` rather than `dist`, update build scripts accordingly
* fix incorrect method binding in WorkerServiceClass#callTargetMethod * add support for 'methods' option in ServiceBinderSpec * include details on new 'methods' option in README * bump package version and update corresponding CDN links in README
* add support for injecting revokeObjectURL mock in place of URL#revokeObjectURL * remove unreachable code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
objective: facilitate import from client-code with dom types