feat: add Range to HTMLComment nodes (#1229)

Co-authored-by: Daniel <daniel@grundel.local>

Author: dgrundel

parser/v2/htmlcommentparser.go

@@ -35,5 +35,6 @@ func (p htmlCommentParser) Parse(pi *parse.Input) (n Node, ok bool, err error) {
 		return
 	}
 
+	c.Range = NewRange(start, pi.Position())
 	return c, true, nil
 }

parser/v2/htmlcommentparser_test.go

@@ -18,13 +18,37 @@ func TestHTMLCommentParser(t *testing.T) {
 			input: `<!-- single line comment -->`,
 			expected: &HTMLComment{
 				Contents: " single line comment ",
+				Range: Range{
+					From: Position{
+						Index: 0,
+						Line:  0,
+						Col:   0,
+					},
+					To: Position{
+						Index: 28,
+						Line:  0,
+						Col:   28,
+					},
+				},
 			},
 		},
 		{
 			name:  "comment - no whitespace",
 			input: `<!--no whitespace between sequence open and close-->`,
 			expected: &HTMLComment{
 				Contents: "no whitespace between sequence open and close",
+				Range: Range{
+					From: Position{
+						Index: 0,
+						Line:  0,
+						Col:   0,
+					},
+					To: Position{
+						Index: 52,
+						Line:  0,
+						Col:   52,
+					},
+				},
 			},
 		},
 		{
@@ -36,20 +60,56 @@ func TestHTMLCommentParser(t *testing.T) {
 				Contents: ` multiline
 								comment
 					`,
+				Range: Range{
+					From: Position{
+						Index: 0,
+						Line:  0,
+						Col:   0,
+					},
+					To: Position{
+						Index: 39,
+						Line:  2,
+						Col:   8,
+					},
+				},
 			},
 		},
 		{
 			name:  "comment - with tag",
 			input: `<!-- <p class="test">tag</p> -->`,
 			expected: &HTMLComment{
 				Contents: ` <p class="test">tag</p> `,
+				Range: Range{
+					From: Position{
+						Index: 0,
+						Line:  0,
+						Col:   0,
+					},
+					To: Position{
+						Index: 32,
+						Line:  0,
+						Col:   32,
+					},
+				},
 			},
 		},
 		{
 			name:  "comments can contain tags",
 			input: `<!-- <div> hello world </div> -->`,
 			expected: &HTMLComment{
 				Contents: ` <div> hello world </div> `,
+				Range: Range{
+					From: Position{
+						Index: 0,
+						Line:  0,
+						Col:   0,
+					},
+					To: Position{
+						Index: 33,
+						Line:  0,
+						Col:   33,
+					},
+				},
 			},
 		},
 	}

parser/v2/templateparser_test.go

@@ -768,9 +768,21 @@ func TestTemplateParser(t *testing.T) {
 				},
 				Children: []Node{
 					&Whitespace{Value: "\t"},
-					&HTMLComment{Contents: " Single line "},
+					&HTMLComment{
+						Contents: " Single line ",
+						Range: Range{
+							From: Position{Index: 13, Line: 1, Col: 1},
+							To:   Position{Index: 33, Line: 1, Col: 21},
+						},
+					},
 					&Whitespace{Value: "\n\t"},
-					&HTMLComment{Contents: "\n\t\tMultiline\n\t"},
+					&HTMLComment{
+						Contents: "\n\t\tMultiline\n\t",
+						Range: Range{
+							From: Position{Index: 35, Line: 2, Col: 1},
+							To:   Position{Index: 56, Line: 4, Col: 4},
+						},
+					},
 					&Whitespace{Value: "\n"},
 				},
 			},

parser/v2/types.go

@@ -1135,6 +1135,7 @@ func (c *GoComment) Visit(v Visitor) error {
 // HTMLComment.
 type HTMLComment struct {
 	Contents string
+	Range    Range
 }
 
 func (c *HTMLComment) IsNode() bool { return true }