refactor: move expressionAttributeValueURL check to separate function (#1206)

Author: grqphical

generator/generator.go

@@ -1344,7 +1344,7 @@ func (g *generator) writeExpressionAttribute(indentLevel int, elementName string
 	}
 	attrKey := html.EscapeString(attr.Key.String())
 	// Value.
-	if (elementName == "a" && attrKey == "href") || (elementName == "form" && attrKey == "action") {
+	if isExpressionAttributeValueURL(elementName, attrKey) {
 		if err := g.writeExpressionAttributeValueURL(indentLevel, attr); err != nil {
 			return err
 		}
@@ -1789,3 +1789,20 @@ func stripTypes(parameters string) string {
 	}
 	return strings.Join(variableNames, ", ")
 }
+
+func isExpressionAttributeValueURL(elementName, attrName string) bool {
+	var elementAttributeLookup = map[string]string{
+		"a":      "href",
+		"form":   "action",
+		"link":   "href",
+		"object": "data",
+	}
+	expectedAttribute, exists := elementAttributeLookup[elementName]
+	if !exists {
+		return false
+	}
+	if attrName != expectedAttribute {
+		return false
+	}
+	return true
+}

generator/generator_test.go

@@ -70,3 +70,38 @@ templ Hello(name string) {
 		t.Errorf("expected an expression for the package name, template signature (Hello) and for the if (nam), got %#v", op.SourceMap.Expressions)
 	}
 }
+
+func TestIsExpressionAttributeValueURL(t *testing.T) {
+	testCases := []struct {
+		elementName    string
+		attrName       string
+		expectedOutput bool
+	}{
+		{
+			elementName:    "a",
+			attrName:       "href",
+			expectedOutput: true,
+		},
+		{
+			elementName:    "a",
+			attrName:       "class",
+			expectedOutput: false,
+		},
+		{
+			elementName:    "div",
+			attrName:       "class",
+			expectedOutput: false,
+		},
+		{
+			elementName:    "p",
+			attrName:       "href",
+			expectedOutput: false,
+		},
+	}
+
+	for _, testCase := range testCases {
+		if output := isExpressionAttributeValueURL(testCase.elementName, testCase.attrName); output != testCase.expectedOutput {
+			t.Errorf("expected %t got %t", testCase.expectedOutput, output)
+		}
+	}
+}