fix: parser: fix memory leak in goexpression.Func (fixes #916) (#935)

utrack · web-flow · commit a4638e3f5f63 · 2024-09-27T10:32:10.000+01:00
diff --git a/parser/v2/goexpression/parse.go b/parser/v2/goexpression/parse.go
@@ -256,7 +256,7 @@ func Func(content string) (name, expr string, err error) {
 			err = errors.New("parser error: function identifier")
 			return false
 		}
-		expr = src[start:end]
+		expr = strings.Clone(src[start:end])
 		name = fn.Name.Name
 		return false
 	})

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ func Func(content string) (name, expr string, err error) {`
`256`	`256`	`err = errors.New("parser error: function identifier")`
`257`	`257`	`return false`
`258`	`258`	`}`
`259`		`- expr = src[start:end]`
	`259`	`+ expr = strings.Clone(src[start:end])`
`260`	`260`	`name = fn.Name.Name`
`261`	`261`	`return false`
`262`	`262`	`})`