fix: incorrect JS parsing when / chars encountered within strings, fixes #1250

Author: a-h

.version

@@ -1 +1 @@
-0.3.943
+0.3.944

parser/v2/scriptparser.go

@@ -130,14 +130,17 @@ loop:
 		for {
 			before := pi.Index()
 
+			// If we're outside of a string literal, check for a regexp literal.
 			// Check for a regular expression literal.
-			r, ok, err := regexpLiteral.Parse(pi)
-			if err != nil {
-				return nil, false, err
-			}
-			if ok {
-				sb.WriteString(r)
-				continue charLoop
+			if stringLiteralDelimiter == jsQuoteNone {
+				r, ok, err := regexpLiteral.Parse(pi)
+				if err != nil {
+					return nil, false, err
+				}
+				if ok {
+					sb.WriteString(r)
+					continue charLoop
+				}
 			}
 
 			// Check for EOF.

parser/v2/scriptparser_test.go

@@ -345,6 +345,22 @@ to see if it works";</script>`,
 				},
 			},
 		},
+		{
+			name: "single line comments after expressions are allowed",
+			input: `<script>
+const category = path.split('/')[2]; // example comment
+</script>`,
+			expected: &ScriptElement{
+				Contents: []ScriptContents{
+					NewScriptContentsScriptCode("\nconst category = path.split('/')[2]; "),
+					NewScriptContentsScriptCode("// example comment\n"),
+				},
+				Range: Range{
+					From: Position{Index: 0, Line: 0, Col: 0},
+					To:   Position{Index: 74, Line: 2, Col: 9},
+				},
+			},
+		},
 		{
 			name: "multiline commented out go expressions are ignored",
 			input: `<script>

parser/v2/scriptparsertestdata/terminating_comment.txt

@@ -0,0 +1,8 @@
+-- in --
+<script>
+const category = path.split('/')[2]; // example comment
+</script>
+-- out --
+
+const category = path.split('/')[2]; // example comment
+