Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local dataset (#208) #211

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Local dataset (#208) #211

merged 1 commit into from
Sep 16, 2022

Conversation

a-r-j
Copy link
Owner

@a-r-j a-r-j commented Sep 16, 2022

  • add load local pdb_files to ProteinGraphDataset

  • load local pdb_files from a list

  • test and black and isort and add CHANGELOG.md

  • docstring formatting

  • comment jupyter; just run and ssh or vscode to interact with container

  • install dependency of jupyter nbextension

  • Fixed Dockerfile and unit tests

  • Update chage log

Co-authored-by: xutingfeng xutingfeng@big.ac.cn
Co-authored-by: Arian Jamasb arjamasb@gmail.com
Co-authored-by: ryan ryan.greenhalgh@hotmail.co.uk

Reference Issues/PRs

What does this implement/fix? Explain your changes

What testing did you do to verify the changes in this PR?

Pull Request Checklist

  • Added a note about the modification or contribution to the ./CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./graphein/tests/* directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under ./notebooks/ (if applicable)
  • Ran python -m py.test tests/ and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., python -m py.test tests/protein/test_graphs.py)
  • Checked for style issues by running black . and isort .

* add load local pdb_files to ProteinGraphDataset

* load local pdb_files from a list

* test and black and isort and add CHANGELOG.md

* docstring formatting

* comment jupyter; just run  and ssh or vscode to interact with container

* install dependency of jupyter nbextension

* Fixed Dockerfile and unit tests

* Update chage log

Co-authored-by: xutingfeng <xutingfeng@big.ac.cn>
Co-authored-by: Arian Jamasb <arjamasb@gmail.com>
Co-authored-by: ryan <ryan.greenhalgh@hotmail.co.uk>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@a-r-j a-r-j merged commit 75b0094 into disulfide_fix Sep 16, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
40.0% 40.0% Duplication

a-r-j added a commit that referenced this pull request Sep 16, 2022
* fix disulphide bond node filtering #205

* Local dataset (#208) (#211)

* add load local pdb_files to ProteinGraphDataset

* load local pdb_files from a list

* test and black and isort and add CHANGELOG.md

* docstring formatting

* comment jupyter; just run  and ssh or vscode to interact with container

* install dependency of jupyter nbextension

* Fixed Dockerfile and unit tests

* Update chage log

Co-authored-by: xutingfeng <xutingfeng@big.ac.cn>
Co-authored-by: Arian Jamasb <arjamasb@gmail.com>
Co-authored-by: ryan <ryan.greenhalgh@hotmail.co.uk>

Co-authored-by: Nicktf <49584439+1511878618@users.noreply.github.com>
Co-authored-by: xutingfeng <xutingfeng@big.ac.cn>
Co-authored-by: ryan <ryan.greenhalgh@hotmail.co.uk>

* fix typo

Co-authored-by: Nicktf <49584439+1511878618@users.noreply.github.com>
Co-authored-by: xutingfeng <xutingfeng@big.ac.cn>
Co-authored-by: ryan <ryan.greenhalgh@hotmail.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants