fix: change MAX_CONTENT_LENGTH (for file attachment) in json-rpc to be larger size (10mb)
#518
Conversation
Summary of ChangesHello @mindpower, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily addresses the limitation of small request body sizes by significantly increasing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully increases the MAX_CONTENT_LENGTH to 10MB as intended. My review includes a minor suggestion to improve the readability of this new constant value.
Additionally, this PR includes significant changes to the uv.lock file, introducing a new [all] optional dependency group and adding uvicorn. These changes seem unrelated to the primary goal of adjusting the content length. To maintain a clean and understandable git history, it's best practice to separate dependency updates into their own pull request, perhaps titled chore(deps): Add 'all' extras and uvicorn.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
holtskinner
changed the title
MAX_CONTENT_LENGTH to be larger size (10mb)
There was a problem hiding this comment.
@mindpower Can you update the Unit Tests to check for a higher value?
Updated the unit tests. |
mindpower
changed the title
MAX_CONTENT_LENGTH to be larger size (10mb)MAX_CONTENT_LENGTH (for file attachment) to be larger size (10mb)
mindpower
changed the title
MAX_CONTENT_LENGTH (for file attachment) to be larger size (10mb)MAX_CONTENT_LENGTH (for file attachment) in json-rpc to be larger size (10mb)
🤖 I have created a release *beep* *boop* --- ## [0.3.10](v0.3.9...v0.3.10) (2025-10-21) ### Features * add `get_artifact_text()` helper method ([9155888](9155888)) * Add a `ClientFactory.connect()` method for easy client creation ([d585635](d585635)) ### Bug Fixes * change `MAX_CONTENT_LENGTH` (for file attachment) in json-rpc to be larger size (10mb) ([#518](#518)) ([5b81385](5b81385)) * correct `new_artifact` methods signature ([#503](#503)) ([ee026aa](ee026aa)) ### Code Refactoring * **utils:** move part helpers to their own file ([9155888](9155888)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Description
The current max content length for file attachment in an A2A request is only 1mb which is too small for most files. Change MAX_CONTENT_LENGTH to be larger size (10mb). (Note currently we only have this limit for json-rpc)
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.bash scripts/format.shfrom the repository root to format)Fixes #<issue_number_goes_here> 🦕