Skip to content

Conversation

@sokoliva
Copy link
Contributor

@sokoliva sokoliva commented Nov 20, 2025

The metadata dictionary is now correctly propagated in both the ToProto (types.Task to a2a_pb2.Task) and FromProto (a2a_pb2.Task to types.Task) conversion utilities.

Fixes #541 🦕

@sokoliva sokoliva requested a review from a team as a code owner November 20, 2025 16:09
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sokoliva, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important bug where task metadata was not being correctly transferred during type conversion. By adding a single line of code, it ensures that the metadata associated with a types.Task is now properly included when converting it to an a2a_pb2.Task, thereby preventing data loss and resolving the identified issue.

Highlights

  • Metadata Propagation: Implemented the propagation of metadata from types.Task objects to a2a_pb2.Task objects within the task conversion method in proto_utils.py.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds metadata propagation from types.Task to a2a_pb2.Task. While the change itself is correct, it is incomplete. The reverse conversion in FromProto.task is missing the metadata field, which will lead to data loss during a round-trip conversion. Additionally, this new functionality is not covered by unit tests. I've added a comment regarding the missing test coverage. To make this fix complete, please also update FromProto.task to handle metadata and add a round-trip test case to verify the behavior.

@sokoliva sokoliva requested a review from lkawka November 20, 2025 16:10
@holtskinner holtskinner changed the title fix: add metadata propagation from types.Task to a2a_pb2.Task in proto_utils.py fix: add metadata propagation from types.Task to a2a_pb2.Task in proto_utils.py Nov 20, 2025
@sokoliva sokoliva changed the title fix: add metadata propagation from types.Task to a2a_pb2.Task in proto_utils.py fix: Ensure metadata propagation for Task ToProto and FromProto conversion Nov 20, 2025
@sokoliva sokoliva merged commit fc31d03 into a2aproject:main Nov 21, 2025
6 checks passed
sokoliva pushed a commit that referenced this pull request Nov 21, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.3.16](v0.3.15...v0.3.16)
(2025-11-21)


### Bug Fixes

* Ensure metadata propagation for `Task` `ToProto` and `FromProto`
conversion ([#557](#557))
([fc31d03](fc31d03))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: proto_utils.py task does not propagate metadata from python type to proto

3 participants