Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build) Remove source map from build distribution #161

Merged

Conversation

jeromesimeon
Copy link
Member

Signed-off-by: Jerome Simeon jeromesimeon@me.com

Issue #142

Trying to address the issue raised in #142 wrt to test coverage in applications importing markdown-transform.

Changes

  • Distinct babel configuration for production build, which does not include Istanbul.
  • Use production build when publishing the packages

Flags

  • I do not understand jest testing very well, I only replicated the fix that occurred in Cicero related to the same issue. I am not sure how to test it either, so could use help with that or a review from someone who understands this better, possibly from @mttrbrts or the issue's originator (@j4m3sb0mb)

Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
@jeromesimeon jeromesimeon merged commit 3400c1b into accordproject:master Feb 7, 2020
@jeromesimeon jeromesimeon deleted the js-fix-sourcemap-142 branch February 8, 2020 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant