Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getGroupValues to use $_REQUEST - Bug7988 #1320

Merged
merged 2 commits into from
Oct 20, 2015
Merged

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Oct 19, 2015

Corrects a bug where page 1 elements of a request on page 2 where included in the update.

@gluneau gluneau added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Oct 19, 2015
@gluneau gluneau added this to the 15.10 milestone Oct 19, 2015
@@ -1319,7 +1324,8 @@ class LorisForm
function getSubmitValues()
{
$retVal = array();
$this->getGroupValues($this->form, $retVal);
$this->getGroupValues(array_keys($_REQUEST), $retVal);
print "VALUES SIZE: " . count($retVal);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be a print statement here..

samirdas added a commit that referenced this pull request Oct 20, 2015
getGroupValues to use $_REQUEST - Bug7988
@samirdas samirdas merged commit 826ed70 into aces:master Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants