Database name is hardcoded in 3 places in instrument manager display errors #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluneau
added
the
Cleanup
| @@ -73,6 +73,7 @@ class NDB_Menu_Filter_instrument_manager extends NDB_Menu_Filter | |||
|
|
|||
| function _setDataTableRows($count) | |||
| { | |||
| $config = NDB_Config::singleton(); | |||
There was a problem hiding this comment.
The config object should be created with NDB_Factory, not the singleton method.. also, I think the Settings object (which can also be created from the factory...) is a cleaner way of getting this since it directly has a Settings->dbName() function to get the database name
|
Fantastic! For 15.10, the Wiki already says these 3 places should be manually edited. |
christinerogers
added
the
Document at Release
driusan
added a commit
that referenced
this pull request
Nov 24, 2015
…-places-in-Instrument-manager-display-errors Database name is hardcoded in 3 places in instrument manager display errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now loading database name from config.