Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added phpoffice/phpexcel to composer #1449

Merged
merged 8 commits into from
Mar 18, 2016
Merged

added phpoffice/phpexcel to composer #1449

merged 8 commits into from
Mar 18, 2016

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Dec 2, 2015

No description provided.

@gluneau gluneau added the Feature PR or issue introducing/requiring at least one new feature label Dec 2, 2015
@gluneau gluneau added this to the 16.04 milestone Dec 2, 2015
@driusan
Copy link
Collaborator

driusan commented Dec 2, 2015

I don't see any point in adding this if it's not used..

@gluneau
Copy link
Contributor Author

gluneau commented Dec 2, 2015

It is step 1, I will be using in it right away in my project Study

@gluneau gluneau added the Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties label Dec 2, 2015
@codecov-io
Copy link

Current coverage is 14.62%

Merging #1449 into 16.04-dev will decrease coverage by -16.98% as of cbc4624

@@            16.04-dev   #1449   diff @@
=========================================
  Files              67     112      +45
  Stmts            7245   18836   +11591
  Branches            0       0         
  Methods                  1046    +1046
=========================================
+ Hit              2290    2755     +465
  Partial             0       0         
- Missed           4955   16081   +11126

Review entire Coverage Diff as of cbc4624

Powered by Codecov. Updated on successful CI builds.

@samirdas samirdas removed the Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties label Mar 15, 2016
driusan
driusan reviewed Mar 15, 2016
View reviewed changes
composer.json
"PHPExcel": "Classes/"
}
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be required. PHPOfficer/PHPExcel is in packagist.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gluneau You might want to add the note to the documentation about now php-xmlwriter is required to successfully go through composer installation process on minimal CenOS 6 (which I did not notice before this latest update 16.02). Alt text.

@driusan driusan mentioned this pull request Mar 15, 2016
Closed
driusan added a commit that referenced this pull request Mar 18, 2016
@driusan
Merge pull request #1449 from gluneau/Update-excel-writing-library
f6fc095 
added phpoffice/phpexcel to composer
@driusan driusan merged commit f6fc095 into aces:16.04-dev Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature PR or issue introducing/requiring at least one new feature
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gluneau @driusan @codecov-io @dyt811 @samirdas