Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical bug fix for detecting conflicts upon data entry completion #1452

Merged
merged 1 commit into from
Dec 11, 2015
Merged

Critical bug fix for detecting conflicts upon data entry completion #1452

merged 1 commit into from
Dec 11, 2015

Conversation

Jkat
Copy link
Contributor

@Jkat Jkat commented Dec 8, 2015

Currently no conflicts are being detected because the 'if' check doesn't work.

@Jkat Jkat added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Dec 8, 2015
@codecov-io
Copy link

Current coverage is 10.97%

Merging #1452 into 16.04-dev will increase coverage by +0.02% as of 35f2092

@@            16.04-dev   #1452   diff @@
=========================================
  Files             103     103       
  Stmts           17751   17751       
  Branches            0       0       
  Methods          1012    1012       
=========================================
+ Hit              1944    1948     +4
  Partial             0       0       
+ Missed          15807   15803     -4

Review entire Coverage Diff as of 35f2092

Powered by Codecov. Updated on successful CI builds.

samirdas added a commit that referenced this pull request Dec 11, 2015
@samirdas
Merge pull request #1452 from Jkat/CriticalDetectConflictsBugFix
5b8dad3 
Critical bug fix for detecting conflicts upon data entry completion
@samirdas samirdas merged commit 5b8dad3 into aces:16.04-dev Dec 11, 2015
@christinerogers christinerogers added this to the 16.04 milestone Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Jkat @codecov-io @driusan @samirdas @christinerogers