Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code cleanup #1467

Merged
merged 2 commits into from
Jan 8, 2016
Merged

code cleanup #1467

merged 2 commits into from
Jan 8, 2016

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Dec 22, 2015

phpcs --standard=docs/LorisCS.xml modules/candidate_list/

@gluneau gluneau added the Cleanup PR or issue introducing/requiring at least one clean-up operation label Dec 22, 2015
@gluneau gluneau added this to the 16.04 milestone Dec 22, 2015
@driusan
Copy link
Collaborator

driusan commented Jan 4, 2016

There's still some problems with whitespace causing it to fail:

FILE: ...ules/candidate_list/php/NDB_Menu_Filter_candidate_list.class.inc
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
 29 | ERROR | [x] Whitespace found at end of line
 31 | ERROR | [x] Whitespace found at end of line
 32 | ERROR | [x] Additional blank lines found at end of doc comment
 38 | ERROR | [x] Equals sign not aligned with surrounding
    |       |     assignments; expected 2 spaces but found 1 space
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

@codecov-io
Copy link

Current coverage is 10.93%

Merging #1467 into 16.04-dev will increase coverage by +0.08% as of 9aa4254

@@            16.04-dev   #1467   diff @@
=========================================
  Files             103     103       
  Stmts           17925   18022    +97
  Branches            0       0       
  Methods          1021    1021       
=========================================
+ Hit              1945    1971    +26
  Partial             0       0       
- Missed          15980   16051    +71

Review entire Coverage Diff as of 9aa4254

Powered by Codecov. Updated on successful CI builds.

samirdas added a commit that referenced this pull request Jan 8, 2016
@samirdas samirdas merged commit 7e078f3 into aces:16.04-dev Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup PR or issue introducing/requiring at least one clean-up operation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants