Visit label as argument can now be used #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluneau
added
the
Bug
| @@ -58,6 +58,7 @@ | |||
| $query = "SELECT ID, subprojectID from session"; | |||
| if (!empty($argv[1]) && $argv[1]!="confirm") { | |||
| $query .=" WHERE visit_label='$argv[1]'"; | |||
There was a problem hiding this comment.
is this query line required? It seems like it's done with a prepared statement below.
There was a problem hiding this comment.
(and if it is, it should be escaped properly..)
There was a problem hiding this comment.
Indeed that first $query does not seem to be used at all, I will remove.
Current coverage is
|
gluneau
changed the title
gluneau
changed the title
samirdas
added a commit
that referenced
this pull request
Jan 8, 2016
…verbose-enough Visit label as argument can now be used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$visit_label was not getting set, so skipping the if statement.
second argument of an array of pselect does not need to be surrounded by single quotes.