Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_checkDate( to Utility::_checkDate( #1518

Merged
merged 1 commit into from
Feb 5, 2016
Merged

_checkDate( to Utility::_checkDate( #1518

merged 1 commit into from
Feb 5, 2016

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Jan 29, 2016

These 3 files are the only files in LORIS that has _checkDate

specific projects will have to check their code as well.

@gluneau gluneau added the Feature PR or issue introducing/requiring at least one new feature label Jan 29, 2016
@gluneau gluneau added this to the 16.04 milestone Jan 29, 2016
@driusan driusan added PassedCodeReview Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) labels Jan 29, 2016
@codecov-io
Copy link

Current coverage is 23.81%

Merging #1518 into 16.04-dev will increase coverage by +0.09% as of 7ea84a4

@@            16.04-dev   #1518   diff @@
=========================================
  Files             110     110       
  Stmts           18456   18439    -17
  Branches            0       0       
  Methods          1025    1025       
=========================================
+ Hit              4378    4391    +13
  Partial             0       0       
+ Missed          14078   14048    -30

Review entire Coverage Diff as of 7ea84a4

Powered by Codecov. Updated on successful CI builds.

ted-strauss-K1 added a commit that referenced this pull request Feb 5, 2016
@ted-strauss-K1
Merge pull request #1518 from gluneau/_checkdate-now-part-of-utility-…
78b7dee 
…class

_checkDate( to Utility::_checkDate(
@ted-strauss-K1 ted-strauss-K1 merged commit 78b7dee into aces:16.04-dev Feb 5, 2016
@christinerogers christinerogers added the Caveat for Existing Projects PR contains changes that might impact the code or accepted practices of current active projects label May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Caveat for Existing Projects PR contains changes that might impact the code or accepted practices of current active projects Feature PR or issue introducing/requiring at least one new feature
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gluneau @codecov-io @driusan @christinerogers @ted-strauss-K1