Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

file name check #1583

Merged
merged 2 commits into from
Mar 4, 2016
Merged

file name check #1583

merged 2 commits into from
Mar 4, 2016

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Mar 3, 2016

No description provided.

@gluneau gluneau added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Mar 3, 2016
@gluneau gluneau added this to the 16.04 milestone Mar 3, 2016
@driusan
Copy link
Collaborator

driusan commented Mar 3, 2016

Looks fine to me, except it's failing Travis because it needs PHPCS run.

@driusan driusan assigned gluneau and unassigned driusan Mar 3, 2016
@codecov-io
Copy link

Current coverage is 14.98%

Merging #1583 into 16.04-dev will decrease coverage by -0.02% as of 6c7d402

@@            16.04-dev   #1583   diff @@
=========================================
  Files             108     108       
  Stmts           18313   18320     +7
  Branches            0       0       
  Methods          1027    1027       
=========================================
- Hit              2747    2745     -2
  Partial             0       0       
- Missed          15566   15575     +9

Review entire Coverage Diff as of 6c7d402

Powered by Codecov. Updated on successful CI builds.

@gluneau gluneau assigned driusan and unassigned gluneau Mar 3, 2016
samirdas added a commit that referenced this pull request Mar 4, 2016
@samirdas
Merge pull request #1583 from gluneau/enfore-file-name-convention
d5d305c 
file name check
@samirdas samirdas merged commit d5d305c into aces:16.04-dev Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@driusan driusan

Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gluneau @driusan @codecov-io @samirdas