Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count every 200, then commit to couchdb #1626

Merged
merged 1 commit into from Mar 18, 2016

Conversation

gluneau
Copy link
Contributor

@gluneau gluneau commented Mar 17, 2016

After every 200 successes, commit the transaction

                // Count every 200 //
                if (($results[$success] % 200) === 0) {
                    $this->CouchDB->commitBulkTransaction();
                    $this->CouchDB->beginBulkTransaction();
                }

@gluneau gluneau added the Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) label Mar 17, 2016
@gluneau gluneau added this to the 16.0 milestone Mar 17, 2016
@driusan
Copy link
Collaborator

driusan commented Mar 17, 2016

Looks good, but if you ran PHPCS on the whole script you should make sure it's added to travis.yml so it's not for nothing.

@codecov-io
Copy link

Current coverage is 14.32%

Merging #1626 into 16.04-dev will decrease coverage by -0.35% as of 3b13d83

@@            16.04-dev   #1626   diff @@
=========================================
  Files             112     112        
  Stmts           18836   18698    -138
  Branches            0       0        
  Methods          1046           +1046
=========================================
- Hit              2764    2679     -85
  Partial             0       0        
+ Missed          16072   16019     -53

Review entire Coverage Diff as of 3b13d83

Powered by Codecov. Updated on successful CI builds.

driusan added a commit that referenced this pull request Mar 18, 2016
Count every 200, then commit to couchdb
@driusan driusan merged commit 397e711 into aces:16.04-dev Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants